Fix for #2063 #2064
Merged
Fix for #2063 #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thread memory pool cleanup upon THREAD_DETACH which is needed when compiled with USE_TLS=1.
embray
commented
Mar 19, 2019
| @@ -1313,6 +1313,13 @@ void blas_memory_free_nolock(void * map_address) { | |||
| free(map_address); | |||
| } | |||
|
|
|||
| #ifdef SMP | |||
There was a problem hiding this comment.
I'll note that this ifdef is completely superfluous, as this entire section is, I believe, technically under an #ifdef SMP. Nevertheless, it us used in several other places in the surrounding code, so I'm just using it here for consistency's sake. Later it will be good to clean this up when refactoring this file.
…o not leak thread handles.
embray
force-pushed
the
cygwin/use-tls-thread-memory-cleanup
branch
from
ddedc88 to
8ba9e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DllMainused in Cygwin did not run the thread memory pool cleanup uponDLL_THREAD_DETACHwhich is needed when compiled withUSE_TLS=1.There is also a
DllMainimplemented in memory.c for some reason, which is not used on Cygwin (just plain Windows), and also has some special bits for when OpenBLAS is used as a static lib. If anyone who understands this better thinks it would be good to use this on Cygwin instead, and has a good idea how it would be nice to get some input on this.But otherwise I don't see a cleaner way to do this. It seems to work perfectly though to fix the memory leak reported in #2063.