Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Azure manylinux1 & clean-up #2124

Merged
merged 1 commit into from
May 9, 2019

Conversation

tylerjereddy
Copy link
Contributor

  • remove some of the steps & comments
    from the original Azure yml template

  • modify the trigger section to use
    develop since OpenBLAS primarily uses
    this branch; use the same batching
    behavior as downstream projects NumPy/
    SciPy

  • remove Travis emulated ARMv6 gcc build
    because this now happens in Azure

  • use documented Ubuntu vmImage name for Azure
    and add in a manylinux1 test run to the matrix
    for older glibc and catching things
    like memory.c invalid argument type in v0.3.6 #2104

[skip appveyor]

* remove some of the steps & comments
from the original Azure yml template

* modify the trigger section to use
develop since OpenBLAS primarily uses
this branch; use the same batching
behavior as downstream projects NumPy/
SciPy

* remove Travis emulated ARMv6 gcc build
because this now happens in Azure

* use documented Ubuntu vmImage name for Azure
and add in a manylinux1 test run to the matrix

[skip appveyor]
@martin-frbg
Copy link
Collaborator

Thanks. (I had already wondered why the default choice of the dormant "master" branch as the trigger appeared to work)

@martin-frbg martin-frbg merged commit e1fc020 into OpenMathLib:develop May 9, 2019
@martin-frbg
Copy link
Collaborator

martin-frbg commented May 9, 2019

Quick Q before I get tempted to mess with the azure file again - is it normal/intended that the Azure jobs show up as three individual lines in the github UI now (one for each individual job and one for the Azure task as such) ? I assume this is a byproduct of converting previous "script" steps to "jobs" ?

@tylerjereddy
Copy link
Contributor Author

is it normal/intended that the Azure jobs show up as three individual lines in the github UI now (one for each individual job and one for the Azure task as such) ? I assume this is a byproduct of converting previous "script" steps to "jobs" ?

Yeah, we asked Microsoft about that downstream & they said the expanded list was working as intended. On balance, I think some maintainers didn't like the extra bloat in the immediate CI list, but it is 10 parallel jobs for open source so we live with it :)

And yes for adding jobs causing expansion of matrix you see right in GitHub. You can also add a matrix directive within a job for sub-expansion if you want like here: https://github.com/numpy/numpy/blob/master/azure-pipelines.yml#L120

That will also have the same effect on display.

@tylerjereddy tylerjereddy deleted the manylinux1_azure branch May 9, 2019 19:15
@martin-frbg
Copy link
Collaborator

So this is just Microsoft trying to be different - it does look like unwanted extra bloat to me, but as long as the qemu jobs get their free 60 minutes of fame I can certainly live with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants