-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean README and enhanced install instructions for protobuf in Docu #715
Conversation
Use placeholder for version |
6eb143b
to
8d887f8
Compare
@pmai, could you please provide the further details on proper linker flags in addition to the instructions in the new file installing_prerequisites.adoc? |
@philipwindecker Thanks a lot for your support with documentation references and your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done. I would recommend using description lists instead of bold formatting because they provide more consistent styling. See https://docs.asciidoctor.org/asciidoc/latest/lists/description/
https://docs.asciidoctor.org/asciidoc/latest/lists/horizontal/
Alternatively, using subsections (level 2 i.e. ===
) would help with automatically creating anchors and entries in the toc.
CCB 2023-05-22: Merge as-is, conflicts to be resolved @pmai |
9989c54
to
6cecadd
Compare
Signed-off-by: Philipp Rosenberger <[email protected]>
for setting up osi Signed-off-by: Philip Windecker <[email protected]>
Signed-off-by: Philipp Rosenberger <[email protected]>
6cecadd
to
fefe981
Compare
Changes have been performed as requested
Reference to a related issue in the repository
Relates to
Add a description
We need better install instructions for static / dynamic linking, so this PR should enhance the README for this.
More explanation should then follow in the OSI documentation, I guess?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: