Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OSC todo comment from source_reference #788

Merged

Conversation

thomassedlmayer
Copy link
Contributor

We should not include todo notes concerning other standards in OSI's documentation. Apparently, such todo notes are prominentely displayed in the documentation menu tree.

grafik

@thomassedlmayer thomassedlmayer added Documentation Everything which impacts the quality of the documentation and guidelines. Quality Quality improvements. labels Mar 12, 2024
@thomassedlmayer thomassedlmayer added this to the V3.7.0 milestone Mar 12, 2024
@pmai pmai added the ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. label Mar 25, 2024
@pmai
Copy link
Contributor

pmai commented Mar 25, 2024

CCB 2024-03-25: Merge as-is.

Signed-off-by: Thomas Sedlmayer <[email protected]>
@pmai pmai force-pushed the fix/remove-osc-todo branch from f8fc9e6 to 6fc2d4a Compare March 25, 2024 11:36
@pmai pmai merged commit 560d759 into OpenSimulationInterface:master Mar 25, 2024
5 checks passed
@jdsika
Copy link
Contributor

jdsika commented Apr 24, 2024

Nice catch :)

Reviewed for v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Everything which impacts the quality of the documentation and guidelines. Quality Quality improvements. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants