Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StrongHash implementation #135

Merged
merged 9 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/compatibility_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
OPENSWIFTUI_WERROR: 1
OPENGRAPH_ATTRIBUTEGRAPH: 1
OPENSWIFTUI_SWIFT_LOG: 0
OPENSWIFTUI_SWIFT_CRYPTO: 0
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -60,6 +61,7 @@ jobs:
OPENSWIFTUI_WERROR: 1
OPENGRAPH_ATTRIBUTEGRAPH: 1
OPENSWIFTUI_SWIFT_LOG: 0
OPENSWIFTUI_SWIFT_CRYPTO: 0
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
steps:
- uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
OPENGRAPH_ATTRIBUTEGRAPH: 1
OPENSWIFTUI_COMPATIBILITY_TEST: 0
OPENSWIFTUI_SWIFT_LOG: 0
OPENSWIFTUI_SWIFT_CRYPTO: 0
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
OPENGRAPH_ATTRIBUTEGRAPH: 1
OPENSWIFTUI_COMPATIBILITY_TEST: 0
OPENSWIFTUI_SWIFT_LOG: 0
OPENSWIFTUI_SWIFT_CRYPTO: 0
OPENSWIFTUI_TARGET_RELEASE: ${{ matrix.release }}
steps:
- uses: actions/checkout@v4
Expand All @@ -35,7 +36,7 @@ jobs:
swift test \
-c debug \
--filter OpenSwiftUITests \
-Xswiftc -warnings-as-errors \
--filter OpenSwiftUICoreTests \
--enable-code-coverage \
--build-path .build-test-debug
xcrun llvm-cov show \
Expand All @@ -47,7 +48,7 @@ jobs:
swift test \
-c release \
--filter OpenSwiftUITests \
-Xswiftc -warnings-as-errors \
--filter OpenSwiftUICoreTests \
--enable-code-coverage \
--build-path .build-test-release
- uses: codecov/codecov-action@v3
Expand Down
17 changes: 5 additions & 12 deletions .github/workflows/ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,14 @@ jobs:
strategy:
fail-fast: false
matrix:
swift_version: ["6.0"]
include:
- container: "swiftlang/swift:nightly-6.0-jammy"
continue-on-error: true
swift_version: ["6.0.1"]
runs-on: ubuntu-22.04
env:
OPENSWIFTUI_WERROR: 1
OPENGRAPH_ATTRIBUTEGRAPH: 0
OPENSWIFTUI_COMPATIBILITY_TEST: 0
OPENSWIFTUI_SWIFT_LOG: 1
OPENSWIFTUI_SWIFT_CRYPTO: 1
container: swift:${{ matrix.swift_version }}-jammy
steps:
- uses: actions/checkout@v4
Expand All @@ -30,28 +28,23 @@ jobs:
swift test \
-c debug \
--filter OpenSwiftUITests \
-Xswiftc -warnings-as-errors \
--filter OpenSwiftUICoreTests \
--enable-code-coverage \
--build-path .build-test-debug
llvm-cov show \
-instr-profile=.build-test-debug/debug/codecov/default.profdata \
.build-test-debug/debug/OpenSwiftUIPackageTests.xctest \
> coverage.txt
continue-on-error: ${{ matrix.continue-on-error }}
id: debug-test
- name: Building and running tests in release mode
run: |
swift test \
-c release \
--filter OpenSwiftUITests \
-Xswiftc -warnings-as-errors \
--filter OpenSwiftUICoreTests \
--build-path .build-test-release
continue-on-error: ${{ matrix.continue-on-error }}
id: release-test
if: steps.debug-test.outcome == 'success'
- uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
verbose: true
continue-on-error: true
if: steps.debug-test.outcome == 'success'
verbose: true
3 changes: 3 additions & 0 deletions .github/workflows/wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ jobs:
include:
- swift_version: "6.0-SNAPSHOT-2024-09-18-a"
continue-on-error: true
- swift_version: "5.10.0-RELEASE"
continue-on-error: false
runs-on: ${{ matrix.os }}
env:
OPENSWIFTUI_WERROR: 1
OPENGRAPH_ATTRIBUTEGRAPH: 0
OPENSWIFTUI_COMPATIBILITY_TEST: 0
OPENSWIFTUI_SWIFT_LOG: 1
OPENSWIFTUI_SWIFT_CRYPTO: 1
steps:
- uses: actions/checkout@v4
- uses: swiftwasm/setup-swiftwasm@v1
Expand Down
24 changes: 22 additions & 2 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ let openSwiftUICompatibilityTestTarget = Target.testTarget(
swiftSettings: sharedSwiftSettings
)

let swiftBinPath = Context.environment["_"] ?? ""
let swiftBinPath = Context.environment["_"] ?? "/usr/bin/swift"
let swiftBinURL = URL(fileURLWithPath: swiftBinPath)
let SDKPath = swiftBinURL.deletingLastPathComponent().deletingLastPathComponent().deletingLastPathComponent().path
let includePath = SDKPath.appending("/usr/lib/swift_static")
let includePath = SDKPath.appending("/usr/lib/swift")

let package = Package(
name: "OpenSwiftUI",
Expand Down Expand Up @@ -213,6 +213,13 @@ extension Target {
swiftSettings.append(.define("OPENSWIFTUI_SWIFT_LOG"))
self.swiftSettings = swiftSettings
}

func addSwiftCryptoSettings() {
dependencies.append(.product(name: "Crypto", package: "swift-crypto"))
var swiftSettings = swiftSettings ?? []
swiftSettings.append(.define("OPENSWIFTUI_SWIFT_CRYPTO"))
self.swiftSettings = swiftSettings
}
}

if attributeGraphCondition {
Expand Down Expand Up @@ -249,6 +256,19 @@ if swiftLogCondition {
openSwiftUITarget.addSwiftLogSettings()
}

#if os(macOS)
let swiftCryptoCondition = envEnable("OPENSWIFTUI_SWIFT_CRYPTO")
#else
let swiftCryptoCondition = envEnable("OPENSWIFTUI_SWIFT_CRYPTO", default: true)
#endif
if swiftCryptoCondition {
package.dependencies.append(
.package(url: "https://github.com/apple/swift-crypto.git", from: "3.8.0")
)
openSwiftUICoreTarget.addSwiftCryptoSettings()
openSwiftUITarget.addSwiftCryptoSettings()
}

let compatibilityTestCondition = envEnable("OPENSWIFTUI_COMPATIBILITY_TEST")
if compatibilityTestCondition {
var swiftSettings: [SwiftSetting] = (openSwiftUICompatibilityTestTarget.swiftSettings ?? [])
Expand Down
24 changes: 22 additions & 2 deletions [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ let openSwiftUICompatibilityTestTarget = Target.testTarget(
swiftSettings: sharedSwiftSettings
)

let swiftBinPath = Context.environment["_"] ?? ""
let swiftBinPath = Context.environment["_"] ?? "/usr/bin/swift"
let swiftBinURL = URL(fileURLWithPath: swiftBinPath)
let SDKPath = swiftBinURL.deletingLastPathComponent().deletingLastPathComponent().deletingLastPathComponent().path
let includePath = SDKPath.appending("/usr/lib/swift_static")
let includePath = SDKPath.appending("/usr/lib/swift")

let package = Package(
name: "OpenSwiftUI",
Expand Down Expand Up @@ -206,6 +206,13 @@ extension Target {
self.swiftSettings = swiftSettings
}

func addSwiftCryptoSettings() {
dependencies.append(.product(name: "Crypto", package: "swift-crypto"))
var swiftSettings = swiftSettings ?? []
swiftSettings.append(.define("OPENSWIFTUI_SWIFT_CRYPTO"))
self.swiftSettings = swiftSettings
}

func addSwiftTestingSettings() {
dependencies.append(.product(name: "Testing", package: "swift-testing"))
var swiftSettings = swiftSettings ?? []
Expand Down Expand Up @@ -248,6 +255,19 @@ if swiftLogCondition {
openSwiftUITarget.addSwiftLogSettings()
}

#if os(macOS)
let swiftCryptoCondition = envEnable("OPENSWIFTUI_SWIFT_CRYPTO")
#else
let swiftCryptoCondition = envEnable("OPENSWIFTUI_SWIFT_CRYPTO", default: true)
#endif
if swiftCryptoCondition {
package.dependencies.append(
.package(url: "https://github.com/apple/swift-crypto.git", from: "3.8.0")
)
openSwiftUICoreTarget.addSwiftCryptoSettings()
openSwiftUITarget.addSwiftCryptoSettings()
}

// Remove the check when swift-testing reaches 1.0.0
let swiftTestingCondition = envEnable("OPENSWIFTUI_SWIFT_TESTING")
if swiftTestingCondition {
Expand Down
Loading
Loading