Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Protobuf Encoder implementation #141

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Oct 9, 2024

No description provided.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 71.73913% with 78 lines in your changes missing coverage. Please review.

Project coverage is 19.86%. Comparing base (70fe2d9) to head (947e49f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...penSwiftUICore/Data/Protobuf/ProtobufEncoder.swift 71.73% 78 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   17.36%   19.86%   +2.49%     
==========================================
  Files         223      223              
  Lines        6471     6744     +273     
==========================================
+ Hits         1124     1340     +216     
- Misses       5347     5404      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit cc6524d into main Oct 9, 2024
9 of 11 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/protobuf_encoder branch October 9, 2024 13:06
@Kyle-Ye Kyle-Ye linked an issue Oct 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete ProtobufEncoder & ProtobufDecoder implementation
1 participant