Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WASI build issue #142

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix WASI build issue #142

merged 2 commits into from
Oct 9, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Oct 9, 2024

Fix WASI pointer overflow. (The only 32 bit platform we support)

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.92%. Comparing base (cc6524d) to head (a779e39).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...OpenSwiftUICore/Util/UnsafePointer+Extension.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   19.86%   19.92%   +0.05%     
==========================================
  Files         223      223              
  Lines        6744     6744              
==========================================
+ Hits         1340     1344       +4     
+ Misses       5404     5400       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye
Copy link
Member Author

Kyle-Ye commented Oct 9, 2024

2 remaining issues:

  • BitwiseCopyable need Swift 6+ compiler
  • PropertyListEncoder is not available on WASI (Seems to be an upstream issue)

@Kyle-Ye Kyle-Ye merged commit fbf68cc into main Oct 9, 2024
11 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/wasi_pointer branch October 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant