Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update View Input and Output #157

Merged
merged 12 commits into from
Nov 17, 2024
Merged

Update View Input and Output #157

merged 12 commits into from
Nov 17, 2024

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Nov 17, 2024

No description provided.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 8.47458% with 540 lines in your changes missing coverage. Please review.

Project coverage is 21.60%. Comparing base (bbcd8be) to head (5cf647f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ources/OpenSwiftUICore/View/Input/ViewInputs.swift 0.00% 108 Missing ⚠️
...iftUICore/Data/Preference/PreferenceCombiner.swift 0.00% 100 Missing ⚠️
...SwiftUICore/Data/Preference/PreferenceBridge.swift 0.00% 99 Missing ⚠️
...iftUICore/Data/Preference/PreferencesOutputs.swift 0.00% 35 Missing ⚠️
...penSwiftUICore/View/Input/ViewInputPredicate.swift 0.00% 33 Missing ⚠️
...iftUICore/View/InterfaceIdiom/InterfaceIdiom.swift 33.33% 32 Missing ⚠️
...wiftUICore/Data/Preference/PreferencesInputs.swift 0.00% 29 Missing ⚠️
...penSwiftUICore/Data/Preference/View_Indirect.swift 0.00% 24 Missing ⚠️
...urces/OpenSwiftUICore/View/Input/ViewOutputs.swift 0.00% 17 Missing ⚠️
.../View/InterfaceIdiom/InterfaceIdiomPredicate.swift 15.38% 11 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   22.10%   21.60%   -0.51%     
==========================================
  Files         234      233       -1     
  Lines        7401     7540     +139     
==========================================
- Hits         1636     1629       -7     
- Misses       5765     5911     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye merged commit 97dcc6c into main Nov 17, 2024
6 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/view_input branch November 17, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant