Skip to content

Corrects the cancellation mechanism of workflows from activities #17871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gvkries
Copy link
Contributor

@gvkries gvkries commented Apr 30, 2025

@deanmarcussen
Copy link
Member

Yes, I'm not convinced using a CancellationToken here was the best idea, but this fixes it, without changing the api much, which is probably for the best.

cancellationToken.ThrowIfCancellationRequested() which is pretty standard usage, later down in an activities usage, will trun it from Aborted to Faulted. But as I said, fixes it without changing the surface of things too much, so LGTM.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow manager incorrectly uses cancellation token to request abort
2 participants