Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Metropolis Pool Booster #2455

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

clement-ux
Copy link
Collaborator

Description

Pool Booster adapter for Metropolis bribes.

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

github-actions bot commented Mar 20, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 3bdac44

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.77%. Comparing base (1c0beb2) to head (3bdac44).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...racts/poolBooster/PoolBoosterFactoryMetropolis.sol 69.23% 4 Missing ⚠️
...ts/contracts/poolBooster/PoolBoosterMetropolis.sol 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2455      +/-   ##
==========================================
+ Coverage   47.05%   47.77%   +0.71%     
==========================================
  Files         100       91       -9     
  Lines        4845     4176     -669     
  Branches     1284     1094     -190     
==========================================
- Hits         2280     1995     -285     
+ Misses       2561     2179     -382     
+ Partials        4        2       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clement-ux clement-ux changed the title Metropolis Pool Booster WIP: Metropolis Pool Booster Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant