Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Pin terser to 3.14.1 #1384

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Pin terser to 3.14.1 #1384

merged 1 commit into from
Feb 3, 2019

Conversation

tomlinton
Copy link
Contributor

First pull request? Read our guide to contributing

Description:

  • Webpack now uses Terser for minification, Terser released a broken package which causes these errors for builds:

TypeError: Cannot read property 'minify' of undefined

Checklist:

  • Test your work and double-check to confirm that you didn't break anything
  • Wrap any displayed ETH addresses with formattedAddress
  • Wrap any new text/strings for translation
  • Run npm run translations if there are any changes to translated strings
  • Map any new environment variables with a default value in the Webpack config
  • Update any relevant READMEs and docs

@tomlinton tomlinton requested a review from micahalcorn February 3, 2019 17:06
micahalcorn
micahalcorn approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@micahalcorn micahalcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌

@tomlinton tomlinton merged commit e11c7fc into master Feb 3, 2019
@tomlinton tomlinton deleted the tomlinton/terser-fix branch February 3, 2019 17:19
@tomlinton tomlinton mentioned this pull request Feb 4, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@micahalcorn micahalcorn micahalcorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomlinton @micahalcorn