RMET-3403 ::: Update development with latest upsteam Version
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If shouldExcludeSubdomain is explicitely set to NO, it was treated the same as YES
Fix 1 bug, and several static analysis warnings
#trivial Pod update Demo App to TrustKit 1.6
Fix CI by swiching to Bitrise
This test had an outdated pinset which caused it to fail. Updated the pinset to include a pin from the current intermediate CA certificate (Let's Encrypt Authority X3)
Observed behavior of TrustKit showed that, when a domain did not have an exact match for a pinset, the first matching pinset config with the IncludeSubdomains flag was selected. This led to unpredictable behavior because of the nature of iterating through dictionary keys. The change in this commit modifies TrustKit's selection algorithm to iterate through all pinset configs and then select the one that is the closest match (e.g, longest domain). This matches the industry best practice set by Google in their native Android pinning implementation, and brings TrustKit's behavior in line with that of TrustKit-Android.
Fix overlapping pinsets
Currently TrustKit can't be packaged in a static Swift Library without modules. "Pod package" fail if TrustKit is in other podspec dependency. Addind this line will generate module maps for swift dependencies.
Adding DEFINES_MODULE Flags
Save & load the SPKI disk cache using secure coding.
Integer overflow check in memory allocation
Fix for Trustkit not building on Xcode 14.3 datatheorem#298
Fix for crash reported on iOS 17 (Security.framework path issue)
- Swap Cloudflare domain with Data Theorem for TSKEndToEndSwizzlingTests - Add PrivacyInfo.xcprivacy to Xcode project for all targets - Remove noop assign
…vacy-Manifest Add Privacy Manifest
…pstream-version # Conflicts: # TrustKit.podspec # TrustKit.xcodeproj/project.pbxproj # TrustKit/Pinning/TSKSPKIHashCache.m # TrustKit/Pinning/pinning_utils.h # TrustKit/Pinning/pinning_utils.m # TrustKitDemo/Podfile # TrustKitDemo/Podfile.lock # TrustKitDemo/Pods/Headers/Private/TrustKit/TSKPinningValidator.h # TrustKitDemo/Pods/Headers/Private/TrustKit/TSKPinningValidatorCallback.h # TrustKitDemo/Pods/Headers/Private/TrustKit/TSKPinningValidatorResult.h # TrustKitDemo/Pods/Headers/Private/TrustKit/TSKTrustDecision.h # TrustKitDemo/Pods/Headers/Private/TrustKit/TSKTrustKitConfig.h # TrustKitDemo/Pods/Headers/Private/TrustKit/TrustKit.h # TrustKitDemo/Pods/Headers/Public/TrustKit/TSKPinningValidator.h # TrustKitDemo/Pods/Headers/Public/TrustKit/TSKPinningValidatorCallback.h # TrustKitDemo/Pods/Headers/Public/TrustKit/TSKPinningValidatorResult.h # TrustKitDemo/Pods/Headers/Public/TrustKit/TSKTrustDecision.h # TrustKitDemo/Pods/Headers/Public/TrustKit/TSKTrustKitConfig.h # TrustKitDemo/Pods/Headers/Public/TrustKit/TrustKit.h # TrustKitDemo/Pods/Local Podspecs/TrustKit.podspec.json # TrustKitDemo/Pods/Manifest.lock # TrustKitDemo/Pods/Pods.xcodeproj/project.pbxproj # TrustKitDemo/Pods/Target Support Files/Pods-TrustKitDemo-ObjC/Pods-TrustKitDemo-ObjC.debug.xcconfig # TrustKitDemo/Pods/Target Support Files/Pods-TrustKitDemo-ObjC/Pods-TrustKitDemo-ObjC.release.xcconfig # TrustKitDemo/Pods/Target Support Files/Pods-TrustKitDemo-Swift/Pods-TrustKitDemo-Swift-Info.plist # TrustKitDemo/Pods/Target Support Files/Pods-TrustKitDemo-Swift/Pods-TrustKitDemo-Swift-frameworks.sh # TrustKitDemo/Pods/Target Support Files/Pods-TrustKitDemo-Swift/Pods-TrustKitDemo-Swift.debug.xcconfig # TrustKitDemo/Pods/Target Support Files/Pods-TrustKitDemo-Swift/Pods-TrustKitDemo-Swift.release.xcconfig # TrustKitDemo/Pods/Target Support Files/TrustKit-framework/TrustKit-framework-Info.plist # TrustKitDemo/Pods/Target Support Files/TrustKit-framework/TrustKit-framework.xcconfig # TrustKitDemo/Pods/Target Support Files/TrustKit-library/TrustKit-library.xcconfig # TrustKitDemo/TrustKitDemo-ObjC/AppDelegate.m # TrustKitDemo/TrustKitDemo-Swift/AppDelegate.swift # TrustKitDemo/TrustKitDemo.xcodeproj/project.pbxproj # TrustKitDemo/TrustKitDemo.xcodeproj/xcshareddata/xcschemes/TrustKitDemo-ObjC.xcscheme # TrustKitDemo/TrustKitDemo.xcodeproj/xcshareddata/xcschemes/TrustKitDemo-Swift.xcscheme
This is the name to use when we need to import the library as a xcframework, instead of a CocoaPod.
OS-ricardomoreirasilva
requested review from
ItsChaceD,
IT-MikeS,
alexgerardojacinto and
OS-martacarlos
and removed request for
a team
|
The |
OS-martacarlos
approved these changes
Oct 28, 2024
alexgerardojacinto
approved these changes
Oct 28, 2024
OS-ricardomoreirasilva
deleted the
chore/rmet-3403/update-to-latest-upstream-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of the PR is to use the latest
upstreamversion -3.0.4- with the customisations made on our side. So, the following was done:upstream's3.0.4tag, available on theupstream/3.0.4branch.Context
https://outsystemsrd.atlassian.net/browse/RMET-3403
Type of changes
Platforms affected
Tests
Manual testing was performed to test the task.
Checklist
RNMT-XXXX <title>