Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

154 notifs ios #48

Merged
merged 4 commits into from
Feb 4, 2025
Merged

154 notifs ios #48

merged 4 commits into from
Feb 4, 2025

Conversation

bohnerjosh
Copy link
Contributor

Fix for notifications not working on iOS

  • added a separate platform application for APNS on AWS

To be able to tell which platform application a device should be created for, I made DeviceOSEnum a required parameter. This is only required for creating the endpointARN. Once the endpoint is created, AWS SNS figures out which device to send notifications to on its own.

use the following env variables:

# AWS SNS SETTINGS
SNS_REGION = us-east-1
FIREBASE_PLATFORM_APPLICATION_ARN = arn:aws:sns:us-east-1:390212030228:app/GCM/EncouragingPrayer
APNS_PROD_PLATFORM_APPLICATION_ARN = arn:aws:sns:us-east-1:390212030228:app/APNS/EncouragingPrayer-APNS-Prod
APNS_DEV_PLATFORM_APPLICATION_ARN = arn:aws:sns:us-east-1:390212030228:app/APNS/EncouragingPrayer-APNS-Prod

@bohnerjosh bohnerjosh added the bug Something isn't working label Feb 4, 2025
@bohnerjosh bohnerjosh self-assigned this Feb 4, 2025
(cherry picked from commit 66e00bd)
Copy link
Member

@ethanjohnsrud ethanjohnsrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving this!

@bohnerjosh bohnerjosh merged commit 624b782 into master Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants