Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Squiz: Scope Closing Brace #353

Merged
merged 7 commits into from
Mar 1, 2024
Merged

[Documentation] Squiz: Scope Closing Brace #353

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87f1d4d
Docs: add documentation for Squiz.WhiteSpace.ScopeClosingBrace
jaymcp Feb 19, 2024
a2ca0b8
Docs: improve documentation for Squiz.WhiteSpace.ScopeClosingBrace
jaymcp Feb 23, 2024
b0906bb
Docs: clarify wording and code samples for Squiz.WhiteSpace.ScopeClos…
jaymcp Feb 26, 2024
daea34d
Docs: combine code examples in Squiz.WhiteSpace.ScopeClosingBrace
jaymcp Feb 26, 2024
20050f1
Docs: improve examples for Squiz.WhiteSpace.ScopeClosingBrace
jaymcp Mar 1, 2024
3d9c5b1
Docs: add missing emphasis in Squiz.WhiteSpace.ScopeClosingBrace
jaymcp Mar 1, 2024
b5cd72f
Docs: improve code examples for Squiz.WhiteSpace.ScopeClosingBrace
jaymcp Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions src/Standards/Squiz/Docs/WhiteSpace/ScopeClosingBraceStandard.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
<documentation title="Scope Closing Brace">
<standard>
<![CDATA[
Indentation of a closing brace must match the indentation of the line containing the opening brace.
]]>
</standard>
<code_comparison>
<code title="Valid: Closing brace aligned with line containing opening brace.">
<![CDATA[
function foo()
{
<em>}</em>

if (!class_exists('Foo')) {
class Foo {
<em>}</em>
<em>}</em>

<?php if ($something) { ?>
<span>some output</span>
<em><?php }</em> ?>
]]>
</code>
<code title="Invalid: Closing brace misaligned with line containing opening brace.">
<![CDATA[
function foo()
{
<em> }</em>

if (!class_exists('Foo')) {
class Foo {
<em>}</em>
<em> }</em>

<?php if ($something) { ?>
<span>some output</span>
<em> <?php }</em> ?>
]]>
</code>
</code_comparison>
<standard>
<![CDATA[
Closing brace must be on a line by itself.
]]>
</standard>
<code_comparison>
<code title="Valid: Close brace on its own line.">
<![CDATA[
enum Foo {
<em>}</em>
]]>
</code>
<code title="Invalid: Close brace on a line containing other code.">
<![CDATA[
enum Foo {<em>}</em>
]]>
</code>
</code_comparison>
</documentation>
Loading