Fix error handling in computeID method #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method iterates over and exports all public keys to compute the certificate identifier. If the key export method fails, the `computeID` method throws an exception. It should instead skip this key and continue processing. This update fixes the issue.
|
NPM package v2.6.6 has been published 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
computeIDmethod in theCryptoCertificateclass has been updated to handle errors when exporting keys. Previously, if the key export method failed, the method would throw an exception and stop processing. Now, if the export fails, the method will skip that key and continue processing. This fix ensures that thecomputeIDmethod can handle errors gracefully and provides a more robust behavior.