Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPhysicalHostName Error Message #1891

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

turetske
Copy link
Collaborator

If K8SPhysicalHostName set in the machine ad, have the plugin output "Hostname: " in the error message.

@turetske turetske requested a review from Saartank January 13, 2025 22:47
@turetske turetske linked an issue Jan 13, 2025 that may be closed by this pull request
@turetske turetske added this to the v7.13.0 milestone Jan 13, 2025
@turetske turetske added the error messages Improvements to error messages label Jan 13, 2025
@turetske
Copy link
Collaborator Author

@Saartank In order to test, setup a local condor pool and then run echo "K8SPhysicalHostName = \"TestHostName\" " | condor_update_machine_ad

Since I can't get the error to occur, you need to adjust the source code to force an error in cmd/plugin.go, the easiest way would be set isConfigErr to be true on line 112.

Then build the code and create a pelican_plugin binary and create a condor_submit file which uses that built binary to transfer some public file, I used pelican://osdf-itb.osg-htc.org/chtc/itb/osdf-pelican/TESTFILE_26.txt

Then run and when it goes into a hold status, run condor_q -hold -long and see that the output sets (Hostname: EmmaTestCondor)

@turetske turetske requested a review from Saartank February 14, 2025 14:50
@turetske turetske requested a review from Saartank February 14, 2025 17:33
@turetske turetske force-pushed the k8sphysicalhostname branch from 7b08b73 to 18d2998 Compare February 14, 2025 21:54
@turetske turetske requested a review from Saartank February 14, 2025 21:54
Copy link
Collaborator

@Saartank Saartank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Saartank Saartank merged commit 2784ff0 into PelicanPlatform:main Feb 14, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Improvements to error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have plugin include K8SPhysicalHostName in the hold message
3 participants