-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory hoarding in the unit test #2028
Merged
brianaydemir
merged 4 commits into
PelicanPlatform:main
from
bbockelm:monitoring_memory_hoarding
Feb 25, 2025
Merged
Reduce memory hoarding in the unit test #2028
brianaydemir
merged 4 commits into
PelicanPlatform:main
from
bbockelm:monitoring_memory_hoarding
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various internal caches in the origin/cache monitoring were filling with temporary session information, causing unpredictable results in the memory "stress test" unit tests. This commit: - Allows monitoring to be turned off completely if desired; labelled as a hidden variable. - Removes the user ID from the users cache as soon as it is used. Since there's a single use case - and no other indication the user ID cache entry isn't needed - we remove it here. - Reduce redundant calls into the ttlcache.
Reduces churn of objects on the heap observed in memory profiles
I modified the test to run for 10,000 iterations, and collected one profile without this PR's changes ( The reduction in allocations:
The reduction in live heap:
|
Keep a back-reference in the user record to the XrdUserId object; this allows us to delete the user ID upon receipt of the disconnect packet.
brianaydemir
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
infrastructure
GitHub Actions, Release management, and CI
internal
Internal code improvements, not user-facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces memory hoarding and memory churn by: