Document restricted characters in fed prefixes #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiemstrawisc
added
documentation
aowen-uwmad
suggested changes
Feb 26, 2025
There was a problem hiding this comment.
Recommend adding a paragraph (at the end?) that details what happens if you try to use one of the disallowed characters.
Does Pelican throw an error? What does it look like? Is it just a warning, but then the service won't be able to communicate with other Pelican services?
|
@aowen-uwmad First round of feedback is incorporated. |
aowen-uwmad
approved these changes
Feb 26, 2025
|
These changes are approved, so I'm overriding the branch protection complaining that Andrew doesn't have write permissions while I sort that out separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot of the way this renders:
