Fix overeager removing of whitespaces conflicting with helm lint #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helm lint (tested with latest at the time - 3.11.2) takes offense to all of the whitespaces being removed before or after a YAML document separator, as this consumes the newline separating the document separator and the apiVersion key immediately following as described in an issue submitted to the helm repository in 2021:
helm/helm#10149
This pull request removes the excessive trimming of whitespaces, but a number of alternative solutions can be done, for instance, removing the YAML document separator at the top of the offending files.