Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Code #19

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Clean Up Code #19

merged 2 commits into from
Sep 12, 2022

Conversation

ProdigyPNPEnthusiast
Copy link
Contributor

Hi, I love your hacks. They are so much better than that stinky Prodigy X.

I'm in high school and pretty good at coding with JavaScript and TypeScript. I found a spot in your code that could be a cleaner and made this pull request. If you like this pull request, could I join your team of collaborators? Just so you know, I made my GitHub account today as my computer programming teacher told me to.

Signed-off-by: ProdigyPNPEnthusiast [email protected]

Signed-off-by: ProdigyPNPEnthusiast <[email protected]>
@afkvido afkvido self-assigned this Sep 12, 2022
@afkvido afkvido self-requested a review September 12, 2022 15:21
@afkvido afkvido added Is: Enhancement New feature or request. Priority: Medium Somewhat important. Category: P-NP Regarding P-NP. labels Sep 12, 2022
@afkvido
Copy link
Contributor

afkvido commented Sep 12, 2022

@ProdigyPNPEnthusiast Hi!

A couple things:

First of all, Welcome to ProdigyPNP, thanks for taking a look!
Secondly, seeing as your commit was made on GitHub.com, it's not impossible, but highly unlikely that you tested your new code. I'll test it this once, but please, test your code next time.
Finally, about joining the collaborator team, I know that perhaps you only made your account today for Computer Science, however with a lack of history, I unfortunately cannot grant such permissions, as at this point, anyone, even Hosted/Eris can pose as you.

Thanks though, I'll test your PR right now.

Copy link
Contributor

@afkvido afkvido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really seems to make the code a lot easier to understand. Nothing seems to break in my tests. too.

It seems like you have replaced all occurrences of variables![0] with app, and variables![1] with game, and just redefined them. This PR seems to actually be very helpful to the source code of P-NP.

Thank you, @ProdigyPNPEnthusiast.
I've added you to the contributor list.

@afkvido afkvido merged commit 41cce01 into ProdigyPNP:master Sep 12, 2022
@afkvido
Copy link
Contributor

afkvido commented Sep 12, 2022

Hi, I love your hacks. They are so much better than that stinky Prodigy X.

thank you!

@Bailey2319
Copy link

How do I use your hacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: P-NP Regarding P-NP. Is: Enhancement New feature or request. Priority: Medium Somewhat important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants