Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a bundle config yaml example #1023

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 3, 2022

Signed-off-by: Wenqi Li [email protected]

Description

adding another example of yaml config and bundle parsing.

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

wyli added 2 commits November 3, 2022 13:46
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma and KumoLiu November 3, 2022 13:52
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just put some comments inline, feel free to ignore them. Thanks!

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 3, 2022

Hi @wyli ,

May I know what's the feature request for this PR? Why add another example?

Thankss.

@wyli
Copy link
Contributor Author

wyli commented Nov 3, 2022

Hi @wyli ,

May I know what's the feature request for this PR? Why add another example?

Thankss.

I got questions about how to use the config, there's no yaml example although the algo templates are based on yaml.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 3, 2022

Hi @wyli ,
May I know what's the feature request for this PR? Why add another example?
Thankss.

I got questions about how to use the config, there's no yaml example although the algo templates are based on yaml.

Hi @wyli ,

This example is a YAML config:
https://github.com/Project-MONAI/tutorials/blob/main/bundle/hybrid_programming/configs/net_inferer.yaml
Or maybe you can change some config of the spleen bundle example to YAML?
https://github.com/Project-MONAI/tutorials/tree/main/bundle/spleen_segmentation/configs

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Nov 3, 2022

Hi @wyli ,
May I know what's the feature request for this PR? Why add another example?
Thankss.

I got questions about how to use the config, there's no yaml example although the algo templates are based on yaml.

Hi @wyli ,

This example is a YAML config: https://github.com/Project-MONAI/tutorials/blob/main/bundle/hybrid_programming/configs/net_inferer.yaml Or maybe you can change some config of the spleen bundle example to YAML? https://github.com/Project-MONAI/tutorials/tree/main/bundle/spleen_segmentation/configs

Thanks.

this is an example compares the python code and the config, I don't think existing ones explain the details.

@wyli wyli merged commit b56e177 into Project-MONAI:main Nov 4, 2022
@wyli wyli deleted the adds-config-demo branch November 4, 2022 08:09
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Wenqi Li <[email protected]>


### Description
adding another example of yaml config and bundle parsing.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants