Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accelerated MAISI and make it compatible with previous DDPM #1953

Merged
merged 69 commits into from
Mar 19, 2025
Merged

Accelerated MAISI and make it compatible with previous DDPM #1953

merged 69 commits into from
Mar 19, 2025

Conversation

Can-Zhao
Copy link
Contributor

@Can-Zhao Can-Zhao commented Mar 11, 2025 •
edited
Loading

Let MAISI tutorial work for more than one version name, and make it compatible with previous DDPM.
Inference Tested with DDPM and RFlow.
Training tested for DDPM and RFlow
Some updates come from isort and black

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Can-Zhao and others added 14 commits March 11, 2025 20:57
@Can-Zhao
rm old json
10e4bf7 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9be20ed 
for more information, see https://pre-commit.ci
@Can-Zhao
reformat
9e6a715 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
reformat
1dff30c 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
reformat
4187565 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
reformat
f448e9e 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
81ea271 
for more information, see https://pre-commit.ci
@Can-Zhao
reformat
a90cbd0 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
reformat
a4c8583 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
reformat
198399c 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
add controlnet notebook
e3eb585 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a1832b2 
for more information, see https://pre-commit.ci
@Can-Zhao
add inference notebook
1c42a83 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
Merge branch 'maisi' of https://github.com/Can-Zhao/tutorials into maisi
d7850db
@Can-Zhao Can-Zhao marked this pull request as ready for review March 11, 2025 23:42
KumoLiu
KumoLiu reviewed Mar 12, 2025
View reviewed changes
Can-Zhao and others added 3 commits March 14, 2025 19:55
@Can-Zhao
readme
5b2c4d7 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7779f0b 
for more information, see https://pre-commit.ci
@Can-Zhao
readme
f145874 
Signed-off-by: Can-Zhao <[email protected]>
@KumoLiu KumoLiu requested a review from binliunls March 16, 2025 08:13
KumoLiu
KumoLiu approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@KumoLiu KumoLiu enabled auto-merge (squash) March 19, 2025 03:47
@Can-Zhao Can-Zhao marked this pull request as draft March 19, 2025 03:54
auto-merge was automatically disabled March 19, 2025 03:54

Pull request was converted to draft

Can-Zhao and others added 5 commits March 19, 2025 04:18
@Can-Zhao
update model
e01a532 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
update model
9ab0b21 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
update test cases
210a063 
Signed-off-by: Can-Zhao <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4b24deb 
for more information, see https://pre-commit.ci
@Can-Zhao
reformat
4c8efcf 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao Can-Zhao marked this pull request as ready for review March 19, 2025 05:58
@Can-Zhao Can-Zhao marked this pull request as draft March 19, 2025 06:17
Can-Zhao added 2 commits March 19, 2025 06:18
@Can-Zhao
OOM
c4c80bb 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao
OOM
039e6fd 
Signed-off-by: Can-Zhao <[email protected]>
@Can-Zhao Can-Zhao marked this pull request as ready for review March 19, 2025 06:28
@Can-Zhao Can-Zhao merged commit 9f6d19f into Project-MONAI:main Mar 19, 2025
6 checks passed
@Can-Zhao Can-Zhao deleted the maisi branch March 19, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongyang0122 dongyang0122 dongyang0122 left review comments

@guopengf guopengf guopengf left review comments

@KumoLiu KumoLiu KumoLiu approved these changes

@binliunls binliunls binliunls left review comments

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Can-Zhao @dongyang0122 @guopengf @KumoLiu @binliunls