Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pydicom version in TCIA tutorial #1958

Merged
merged 2 commits into from
Mar 19, 2025
Merged

Fix pydicom version in TCIA tutorial #1958

merged 2 commits into from
Mar 19, 2025

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Mar 19, 2025

Fixes #1901

Description

The _storage_sopclass_uids module has been removed since version 3.0. pydicom-seg didn't update accordingly, we can only fixed the version for now.
https://pydicom.github.io/pydicom/dev/release_notes/index.html#removals
https://www.piwheels.org/project/pydicom-seg/

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: YunLiu <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma March 19, 2025 09:12
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks fine for now, hopefully pydicom-seg gets updated.

@ericspod ericspod enabled auto-merge (squash) March 19, 2025 23:20
@ericspod ericspod merged commit 840a399 into main Mar 19, 2025
6 checks passed
@ericspod ericspod deleted the fix-tcia branch March 19, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with pydicom_seg while running TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb in Colab
2 participants