Code

Bug/ios icloud not syncing#2395

Code

Open

JoeMatt wants to merge 135 commits intoProvenance-Emu:developProvenance-Emu/Provenance:developfrom pabloarista:bug/ios-icloud-not-syncingpabloarista/Provenance:bug/ios-icloud-not-syncingCopy head branch name to clipboard

Commits

Commits on Jan 14, 2025

• added check for L3 and R3 buttons for older controllers

  pabloarista

  committed
  a33a1b6

  Copy full SHA for a33a1b6

• updated minimum to 16.0

  pabloarista

  committed
  efe7ae6

  Copy full SHA for efe7ae6

• updated to use variables for app groups and icloud container

  pabloarista

  committed
  be7da84

  Copy full SHA for be7da84

• added todo to test without .icloud relative

  pabloarista

  committed
  c6224c9

  Copy full SHA for c6224c9

• added todo to test without .icloud relative

  pabloarista

  committed
  bd7eb34

  Copy full SHA for bd7eb34

• fix for icloud URL paths that duplicates the root directories

  pabloarista

  committed
  a852aea

  Copy full SHA for a852aea

• added a check for nil

  pabloarista

  committed
  c5ee69e

  Copy full SHA for c5ee69e

• added comment of encoded space to review

  pabloarista

  committed
  f5fad8b

  Copy full SHA for f5fad8b

• removed duplicate entry

  pabloarista

  committed
  2a8ac49

  Copy full SHA for 2a8ac49

Commits on Jan 18, 2025

• updated project file to use build variables

  pabloarista

  committed
  263da3b

  Copy full SHA for 263da3b

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  343d11c

  Copy full SHA for 343d11c

Commits on Jan 19, 2025

• removed TODOs

  pabloarista

  committed
  f6c1558

  Copy full SHA for f6c1558

Commits on Jan 20, 2025

• added notification when ROM db finishes initializing; updated cloudsync to find undownloaded files and download them and send a notification so roms can be imported

  pabloarista

  committed
  a788cab

  Copy full SHA for a788cab

Commits on Jan 21, 2025

• updated type

  pabloarista

  committed
  983534c

  Copy full SHA for 983534c

• reverted

  pabloarista

  committed
  002cc14

  Copy full SHA for 002cc14

Commits on Jan 23, 2025

• updated to send notiifcations when new icloud files have been downloaded; fixed wrong notification observing

  pabloarista

  committed
  880df35

  Copy full SHA for 880df35

• updated to use notification name

  pabloarista

  committed
  7b4cafa

  Copy full SHA for 7b4cafa

• reverted

  pabloarista

  committed
  d2c820a

  Copy full SHA for d2c820a

Commits on Jan 24, 2025

• reverted TODOs

  pabloarista

  committed
  cf81ec7

  Copy full SHA for cf81ec7

• added downloading of battery saves, bios and screenshots; added todo on crash that occurs when realm is being used by the different iCloud syncing that causes the crash

  pabloarista

  committed
  c517f8c

  Copy full SHA for c517f8c

Commits on Jan 25, 2025

• refactored notification names to notification.swift and updated naming convention; removed importing from app delegate; added TODOs

  pabloarista

  committed
  676d579

  Copy full SHA for 676d579

• reverted

  pabloarista

  committed
  b6443a9

  Copy full SHA for b6443a9

• updated to use dlog

  pabloarista

  committed
  cfe6e98

  Copy full SHA for cfe6e98

• added more logs; remove tasks that were causing synchronization issues when saving save states on realm

  pabloarista

  committed
  bf02d64

  Copy full SHA for bf02d64

• added todo; remove task because it was causing crashes when syncing with iCloud due to realm

  pabloarista

  committed
  c0520d4

  Copy full SHA for c0520d4

Commits on Jan 26, 2025

• removed unused functions; refacored to wait for signal that file finishes downloading insetad of checking in a loop; updated to import only roms and just download any extra files that are part of t…

  Show description for 7d7e0bd
  pabloarista

  committed
  7d7e0bd

  Copy full SHA for 7d7e0bd

• removed unused function

  pabloarista

  committed
  7d090bf

  Copy full SHA for 7d090bf

• added deleting of ROMs when file is deleted on icloud

  pabloarista

  committed
  a8931cb

  Copy full SHA for a8931cb

• added todo for deleting savestate

  pabloarista

  committed
  82ad54e

  Copy full SHA for 82ad54e

Commits on Jan 27, 2025

• added todo

  pabloarista

  committed
  ed2a2ad

  Copy full SHA for ed2a2ad

• removed field

  pabloarista

  committed
  07f1b58

  Copy full SHA for 07f1b58

• refactored to listen for changes on icloud sync switch and init icloud when the flag is on and remove observers when off;

  pabloarista

  committed
  e7d416e

  Copy full SHA for e7d416e

• reverted

  pabloarista

  committed
  96deb54

  Copy full SHA for 96deb54

• added TODO

  pabloarista

  committed
  15ef275

  Copy full SHA for 15ef275

• added updating game importer's roms path that was causing issuing when turning icloud on and off

  pabloarista

  committed
  fb8a981

  Copy full SHA for fb8a981

• added TODO for review

  pabloarista

  committed
  6a8b45e

  Copy full SHA for 6a8b45e

Commits on Jan 28, 2025

• added check for invalid path on PVImageFile

  pabloarista

  committed
  92e5400

  Copy full SHA for 92e5400

Commits on Feb 2, 2025

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  2b1d62c

  Copy full SHA for 2b1d62c

Commits on Feb 3, 2025

• added todo

  pabloarista

  committed
  0edab03

  Copy full SHA for 0edab03

• updated to use DLOG instead of print; added condition when root is iCloud and partial path is local path to fix the path

  pabloarista

  committed
  1fe056d

  Copy full SHA for 1fe056d

• updated cache to save locally; updated debug log print statement

  pabloarista

  committed
  b5d647f

  Copy full SHA for b5d647f

• added todo

  pabloarista

  committed
  1757a7f

  Copy full SHA for 1757a7f

Commits on Feb 4, 2025

• updated save path

  pabloarista

  committed
  254d5ba

  Copy full SHA for 254d5ba

• removed unused code; updated try to not force on Realm in case of db error

  pabloarista

  committed
  0de1a03

  Copy full SHA for 0de1a03

• removed unused closure onCompleted

  pabloarista

  committed
  cbe334e

  Copy full SHA for cbe334e

• removed commented out code

  pabloarista

  committed
  bfd7b14

  Copy full SHA for bfd7b14

Commits on Feb 6, 2025

• added recursive code to move files from local to icloud container

  pabloarista

  committed
  561be70

  Copy full SHA for 561be70

Commits on Feb 7, 2025

• updated to get correct files and tree and to identify directories that need to be created and new location of cloud file

  pabloarista

  committed
  7bbf493

  Copy full SHA for 7bbf493

• Finished main code to move files to cloud container

  pabloarista

  committed
  957fc53

  Copy full SHA for 957fc53

• added check if file exists in cloud and deleting local version

  pabloarista

  committed
  1c0529d

  Copy full SHA for 1c0529d

• fixed check for directory, added uploader for ROMs

  pabloarista

  committed
  ed1eff4

  Copy full SHA for ed1eff4

• added TODO

  pabloarista

  committed
  c70e781

  Copy full SHA for c70e781

Commits on Feb 9, 2025

• updated relativeRoot and added todos to check invalid paths

  pabloarista

  committed
  0827eb9

  Copy full SHA for 0827eb9

• added debug block

  pabloarista

  committed
  fe25a22

  Copy full SHA for fe25a22

• reverted returns; updated TODO text

  pabloarista

  committed
  aac5da6

  Copy full SHA for aac5da6

• moved upload icloud to syncer class; added enumeration status icloud upload; added importing already downloaded files when switching icloud on; added deleting saves from db when syncing from icloud…

  Show description for ed86647
  pabloarista

  committed
  ed86647

  Copy full SHA for ed86647

• updated to use notificationCenter directly and removed unused NotificationObserver

  pabloarista

  committed
  e83acf7

  Copy full SHA for e83acf7

• added userdefaults to know when to initially import files from cloud

  pabloarista

  committed
  e1e599a

  Copy full SHA for e1e599a

• added removal of icloud files when flag is turned off; added todo on working with existing files in icloud container

  pabloarista

  committed
  7f40843

  Copy full SHA for 7f40843

• updated to use shared function

  pabloarista

  committed
  4803b01

  Copy full SHA for 4803b01

• removed finished todo

  pabloarista

  committed
  2c7cd85

  Copy full SHA for 2c7cd85

• updated initializer

  pabloarista

  committed
  8f68d4f

  Copy full SHA for 8f68d4f

• refactored to merge files that do NOT have db entry into a single class; fixed files not storing correctly when turning off icloud

  pabloarista

  committed
  46465be

  Copy full SHA for 46465be

• fixed battery states directory name

  pabloarista

  committed
  390ef40

  Copy full SHA for 390ef40

Commits on Feb 10, 2025

• updated to add full error; added check for storage available

  pabloarista

  committed
  441831f

  Copy full SHA for 441831f

• removed unused field

  pabloarista

  committed
  7027201

  Copy full SHA for 7027201

• refactored insert code into base class; updated logs; remove unnecessary use of user defaults flag; updated logic so initial opening of app or switching icloud on tries to import anything already d…

  Show description for 8b39cab
  pabloarista

  committed
  8b39cab

  Copy full SHA for 8b39cab

Commits on Feb 15, 2025

• added error queue to store errors when syncing with iCloud

  pabloarista

  committed
  c2f97f7

  Copy full SHA for c2f97f7

• refactored move files to reduce nesting; updated to handle the case when importer is curently importing files and to do the importing when it finishes

  pabloarista

  committed
  99b490a

  Copy full SHA for 99b490a

Commits on Feb 16, 2025

• added deleting of json file when deleting save states; added trying to get system from icloud parent directory

  pabloarista

  committed
  281b0bf

  Copy full SHA for 281b0bf

• added confirmation when deleting a ROM

  pabloarista

  committed
  387b539

  Copy full SHA for 387b539

• added deletion of db items when deleted from icloud; fixed extension check; fixed predicate; updated to check if file exists first

  pabloarista

  committed
  6029c61

  Copy full SHA for 6029c61

• updated alerts

  pabloarista

  committed
  21d3100

  Copy full SHA for 21d3100

• fixed bug when deleting file and then re-adding the same file by removing game from cache after deletion either from manual deletion or icloud sync deletion

  pabloarista

  committed
  ed04206

  Copy full SHA for ed04206

Commits on Feb 17, 2025

• fixed deletion of ROM and related files

  pabloarista

  committed
  5e2c599

  Copy full SHA for 5e2c599

• removed unused storage code

  pabloarista

  committed
  d110632

  Copy full SHA for d110632

• refactored code to get indexset to fix index out of bounds when multiple items in queue are removed; added deletion of games when the application is closed and the cloud container ROMs are removed

  pabloarista

  committed
  43e47c4

  Copy full SHA for 43e47c4

• refactored to defer instead of duplicating code; updated to check for different kinds of multiple disc ROM files; fixed comment

  pabloarista

  committed
  06d6612

  Copy full SHA for 06d6612

• updated localization

  pabloarista

  committed
  edae4e7

  Copy full SHA for edae4e7

Commits on Feb 18, 2025

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  c86939a

  Copy full SHA for c86939a

• removed unused variable

  pabloarista

  committed
  7909e06

  Copy full SHA for 7909e06

Commits on Feb 19, 2025

• updated to process 10 ROMs at a time.

  pabloarista

  committed
  3d3e2e1

  Copy full SHA for 3d3e2e1

• added todo

  pabloarista

  committed
  3459b90

  Copy full SHA for 3459b90

Commits on Feb 22, 2025

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  8a3dc47

  Copy full SHA for 8a3dc47

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  0c4da8b

  Copy full SHA for 0c4da8b

• fixed compilation issues

  pabloarista

  committed
  d12cbc8

  Copy full SHA for d12cbc8

Commits on Feb 23, 2025

• added sending signal on the main queue

  pabloarista

  committed
  b12269d

  Copy full SHA for b12269d

• removed extra parenthesis

  pabloarista

  committed
  3f7911b

  Copy full SHA for 3f7911b

• added more logs, change foreach to synchronous to handle the case when the app first loads or the user turns on icloud and icloud files are already downloaded, but not imported

  pabloarista

  committed
  ce2594b

  Copy full SHA for ce2594b

• added processing of save files in batches;

  pabloarista

  committed
  71c5e33

  Copy full SHA for 71c5e33

• updated error logs to include file and to use correct log function; updated to use barrier dispatch queue when modifying netFiles set

  pabloarista

  committed
  d11db73

  Copy full SHA for d11db73

• refactored duplicate code

  pabloarista

  committed
  60b9894

  Copy full SHA for 60b9894

Commits on Feb 24, 2025

• updated print statements

  pabloarista

  committed
  77f4711

  Copy full SHA for 77f4711

Commits on Mar 1, 2025

• added build variable

  pabloarista

  committed
  9e1b259

  Copy full SHA for 9e1b259

• added build variables

  pabloarista

  committed
  4c26f02

  Copy full SHA for 4c26f02

• project file fix

  pabloarista

  committed
  cfbd5a9

  Copy full SHA for cfbd5a9

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  2a99963

  Copy full SHA for 2a99963

• xcode auto project file update

  pabloarista

  committed
  6e19cd6

  Copy full SHA for 6e19cd6

• more xcode project file updates

  pabloarista

  committed
  6b07ae8

  Copy full SHA for 6b07ae8

• added comments; refactored importer code to defer with new logic; added destination url variable; updated logic to check importer is NOT processing and NOT paused; updated guard to check if file ex…

  Show description for 516d671
  pabloarista

  committed
  516d671

  Copy full SHA for 516d671

• removed empty queue

  pabloarista

  committed
  27640bd

  Copy full SHA for 27640bd

• added more localization; and updated function signatures

  pabloarista

  committed
  b432ef5

  Copy full SHA for b432ef5

• added todos and prints

  pabloarista

  committed
  39c4682

  Copy full SHA for 39c4682

• removed todos; fixed logic to handle all cases when deleting multi-disc ROMs

  pabloarista

  committed
  b5c0f10

  Copy full SHA for b5c0f10

• Added extension for localization strings

  pabloarista

  committed
  72b19ad

  Copy full SHA for 72b19ad

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  051d77d

  Copy full SHA for 051d77d

Commits on Mar 2, 2025

• added comments; removed unused code; updated to wait for db to be initialized before trying to download/process ROMs/Saves because we want to use the game cache to speed things up and not hit the d…

  Show description for 817c141
  pabloarista

  committed
  817c141

  Copy full SHA for 817c141

Commits on Mar 3, 2025

• updated to use cache in order to only hit the db when necessary; added todo

  pabloarista

  committed
  b6b508b

  Copy full SHA for b6b508b

• removed unused code; refactored code to be reused; updated to use data from cache

  pabloarista

  committed
  7286377

  Copy full SHA for 7286377

• added date/time to logs; added process/memory info; updated text to show pending to process;

  pabloarista

  committed
  e084f80

  Copy full SHA for e084f80

Commits on Mar 8, 2025

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  18c3a9f

  Copy full SHA for 18c3a9f

• refactored pathDecoded code to URL+Extensions; updated batch process to 1; updated some logs to information; updated icloud container identifier to use build variable

  pabloarista

  committed
  e530742

  Copy full SHA for e530742

• removed unused code

  pabloarista

  committed
  1953a46

  Copy full SHA for 1953a46

Commits on Mar 9, 2025

• fixed importer having files pendingn to import; removed processor information

  pabloarista

  committed
  34d63ab

  Copy full SHA for 34d63ab

• removed commented out code

  pabloarista

  committed
  0d61eb4

  Copy full SHA for 0d61eb4

• Removed mainActor;

  pabloarista

  committed
  24f6d39

  Copy full SHA for 24f6d39

• removed import saves before all are ready to process

  pabloarista

  committed
  5a348d9

  Copy full SHA for 5a348d9

• fixed processing saved to work on a background thread; added a sleep of 5 seconds to avoid hangs that still occur even on background thread

  pabloarista

  committed
  38fb5c6

  Copy full SHA for 38fb5c6

Commits on Mar 10, 2025

• added concurrent set and converted queue into concurrent queue; removed unused code; updated to process saves as they come in;

  pabloarista

  committed
  6cc1756

  Copy full SHA for 6cc1756

• updated type

  pabloarista

  committed
  53d1369

  Copy full SHA for 53d1369

Commits on Mar 11, 2025

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  223224c

  Copy full SHA for 223224c

• added concurrent dictionary; added property to get multi file name key for storing in a bucket to process

  pabloarista

  committed
  0fa58f0

  Copy full SHA for 0fa58f0

Commits on Mar 12, 2025

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  93639d7

  Copy full SHA for 93639d7

• added description on concurrent collections; removed unused local sets; added dictionary for multi files ROMs;

  pabloarista

  committed
  5d98441

  Copy full SHA for 5d98441

Commits on Mar 13, 2025

• removed unused function; added purging of saves from database when application was closed and saves were deleted on a different device;

  pabloarista

  committed
  06abc08

  Copy full SHA for 06abc08

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  be266fe

  Copy full SHA for be266fe

Commits on Mar 14, 2025

• added observing of files to account for nsmetadataquery bug when waiting for large number of files to finish downloading; updated to use Combine API

  pabloarista

  committed
  bfbec4e

  Copy full SHA for bfbec4e

Commits on Mar 15, 2025

• added comment showing different prefix for icloud container

  pabloarista

  committed
  053cd08

  Copy full SHA for 053cd08

• fixed deadlock on concurrent collections; refactored some functions to make them cleaner to read; refactored observer code and added todo;

  pabloarista

  committed
  802387d

  Copy full SHA for 802387d

Commits on Mar 16, 2025

• updated set to use URL; removed filter on combine API; added disabling/enabling updates because without it large libraries are unable to get signals that files finished downloading; added more file…

  Show description for 2f74139
  pabloarista

  committed
  2f74139

  Copy full SHA for 2f74139

• added new notification for when saves batch finishes importing; cleaned up guard statements into a single one

  pabloarista

  committed
  f203e4e

  Copy full SHA for f203e4e

• refactored from dispatchqueue to actor

  pabloarista

  committed
  5a41606

  Copy full SHA for 5a41606

• reverted collections from actor to dispatchqueue

  pabloarista

  committed
  31a3ec0

  Copy full SHA for 31a3ec0

• removed processing rom after each insert

  pabloarista

  committed
  b7c0d78

  Copy full SHA for b7c0d78

• Merge branch 'develop' into bug/ios-icloud-not-syncing

  pabloarista

  committed
  e284a57

  Copy full SHA for e284a57