Make infos length consistent #172
Open
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current vector environments will not send infos that are empty ({} or []). If the environment ever returns {} for infos they will not be added to the infos list, causing it to have fewer elements and making it impossible to determine which environment each info dictionary belongs to. You're likely to run into this issue if you use infos to send crucial training information that isn't available during reset, or while debugging an environment that uses infos.
This PR removes the checks that prevent empty infos from being sent. I'm not sure what issue they were originally supposed to prevent, but I think it is good practice to have the infos length always equal the number of environments.