This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Fix CI for python 3.6 #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
reviewed
May 17, 2021
sambhav
reviewed
May 17, 2021
bump version and add Python 3.9 trove classifier
|
One thing that irks me is why the CI suddenly started failing. I am guessing it is because of the new version of click that was released. Instead of changing the locale, you may want to limit the click version to click<8.0 in the dev requirements instead and see if that fixes the issue. |
|
I think, the locale setting update worked. I'd rather fix the CI directly than pinning dependency versions as it doesn't look like the new click version actually broke any behaviour. But I can also pin the version if you insist. |
|
Since this is just used by black (for development only) I am fine either way. |
sambhav
approved these changes
May 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f710d32.
This closes #540.