-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds all latest GEM datasets. #110
Conversation
for more information, see https://pre-commit.ci
Whilst updating GCPT I noticed that the pm.powerplants(update_all=True) However this now does nothing as
@FabianHofmann what do you think about this? Would be good to update the |
Hey @Tomkourou, indeed we should fix this. It should be |
And thanks btw. Let me know when this is ready to review :) |
Ready to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool! :) Before delving into code optimization some comments in this review.
Additional to the comments, do you think it might make sense to report how the powerplant capacity per carrier changed? Like comparing pre-contribution capacity per carrier vs after contribution.
Here is the analysis with the standard European target_country list: original dataset: ENTSOE, GEO, GPD, JRC, OPSD, BEYONDCOAL, WIKIPEDIA, GGPT
(updated with Nuclear and Biomass) |
Hi @Tomkourou, @Tomkourou , could you update your above plot with the new nuclear and bioenergy data? @FabianHofmann, in case you start reviewing, one minor remaining question. Given a
Should we add something like |
Add nuclear and bioenergy
@Tomkourou , could you update your above plot with the new nuclear and bioenergy data? @FabianHofmann, in case you start reviewing, one minor remaining question. Given a
Should we add something like That's a good question. Until now I didn't have any problems with this but that was because I was using the GEM unit ids or phase ids for renewables instead of project ids. If you use projectids it will probably throw an error since there will be duplicates. |
@Tomkourou Will be reviewed on Monday 👍 |
thanks @Tomkourou! looks all very nice! |
@Tomkourou one question: You added that the GEM datasets are not reporting net capacity. Do you remember where you got this information from? I cannot find it on the GEM page. Since PPM should report net capacity, this might lead to some issues if we do not rescale the capacities. Thanks! |
@FabianHofmann it's a good question. My understanding was that since most GEM datasets include multiple units for powerplants then they needed to be summed up in the process and that's why I categorised them as not reporting net capacity. Perhaps I misunderstood the meaning of net capacity though and it needs to be recategorised? |
@Tomkourou thanks for your answer! Actually, the correct tag for that would be |
Closes #80 and closes #81.
Change proposed in this Pull Request
Adds all the latest datasets from GEM. Including Geothermal, Wind, Solar, Gas & Coal.
Type of change
Checklist
doc/release_notes.rst
.pre-commit run --all
to lint/format/check my contributiondoc/
.