-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for iterable datasets when val_check_interval=1.0 #1283
Merged
williamFalcon
merged 2 commits into
Lightning-AI:master
from
ethanwharris:feature/iterable_val_check
Mar 29, 2020
Merged
Add support for iterable datasets when val_check_interval=1.0 #1283
williamFalcon
merged 2 commits into
Lightning-AI:master
from
ethanwharris:feature/iterable_val_check
Mar 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
+ Coverage 92% 92% +<1%
=======================================
Files 61 61
Lines 3153 3164 +11
=======================================
+ Hits 2886 2897 +11
Misses 267 267 |
the multiline bool expression is quite hard to read... |
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Mar 30, 2020
…ing-AI#1283) * Add support for iterable datasets when val_check_interval=1.0 * Update CHANGELOG.md
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 1, 2020
…ing-AI#1283) * Add support for iterable datasets when val_check_interval=1.0 * Update CHANGELOG.md
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
…ing-AI#1283) * Add support for iterable datasets when val_check_interval=1.0 * Update CHANGELOG.md
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
…ing-AI#1283) * Add support for iterable datasets when val_check_interval=1.0 * Update CHANGELOG.md
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
…ing-AI#1283) * Add support for iterable datasets when val_check_interval=1.0 * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #1252
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃