A lot of changes: Kotlin, time/date formatting fixes, demo activity for whole view snapping... #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added ability to scroll whole view (entire week, for example) like a ViewPager. -made default first day of week to be the one of the calendar.
…es some delicate work. -fixed some time/date formatting related issues: alamkanak#497 alamkanak#495 (but not fixed RTL alignment issue) -created a new activity to demonstrate the paging of entire view (example: week by week snapping), based on this pull request: Quivr#88
This was referenced May 7, 2018
Quivr#98 -added a feature to put text next to the week days -added a feature to set only the week days to have a background, instead of week-days and all-day events. -replaced Java "List" class with "MutableList" instead of Kotlin "List", to avoid possible crashes at runtime (because Kotlin "List" cannot be modified and is more restricted). That being said, I think in most cases, it's ok to use Kotlin "List", because in many cases you don't really need to modify the lists. -some code cleaning and refactoring, including conversion of some fields to be Kotlin properties (setters and getters near the field itself)
replaced findViewById with synthetic ones of Kotlin.
Removed old fonts, using Lato font, which is more modern and used on Android's latest versions. fixed issues of fonts, which didn't apply to all texts. getting fonts by using the support library.
…e dates being shown in the headers.
…of current time&date. You can test it by setting the time of the day to be 23:59, and wait a minute... cleaned code a bit.
added a way to draw the line seperators horizontally&vertically in a way that makes them as in "checkers" (rectangles), by using isUsingCheckersStyle. This is demonstrated in WholeViewSnappingActivity.
Fix scroll snapping
-renamed and fixed some fields that are related to padding/margins, to make it clear what they are intended for.
-renamed and fixed some fields that are related to padding/margins, to make it clear what they are intended for.
fixed issue of inconsistency of short vs long text. Now will show short text whenever you switch to week view.
…mean. added ability to set subtitle text below the week-day title text. Demonstrated in WholeViewSnappingActivity. replaced deprecated clipRect function with the more recommended one, as written here: https://stackoverflow.com/q/50231950/878126
…too slow. -from now on, dropping is automatically enabled by having its listener. If set to null (or not set at all), it's turned off.
-Minor bugs fixes -Minor optimizations to make drawing and scrolling smoother
…rt-time and end-time, because if the end time is the same, it should still be considered ok. - removed deprecated long id, because it's too common for calendar services to use String instead
…tting them into multiple events
added CTOR for all-day event that takes a single day.
…le, using `untitledEventText`
added getters to some of the inner fields, so that you can put views on top of the WeekView on the correct places. replaced the time auto-update mechanism that used Handler to update every minute. Now uses proper BroadcastReceiver instead.
fixed issue of not getting correct lastVisibleDate.
… there are multiple of them from same calendar, it looks bad. minor performance improvements.
… there are multiple of them from same calendar, it looks bad. minor performance improvements.
…id-Week-View into develop # Conflicts: # library/src/main/java/com/alamkanak/weekview/WeekView.kt
…he current year. minor improvements.
Updated to use Android-X instead of support library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.