Automatically retry enqueuing after connection reset #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DB connection is dropped for any reason, QC does
reset
the connection but does not retry enqueuing the job.This PR adds retry-once logic to
enqueue
andenqueue_in
(and through that toenqueue_at
) so that when the initialexecute
fails withPGError
, it is retried once (after execute's rescue has reset the connection).Rationale: QC should give it's best to ensure the
enqueue
results in a enqueued job in DB, so if the DB connection has gone bad, resetting it is not enough and we should repeat theINSERT
also. Leaving the retry logic to the app code is sub-optimal as then everybody need to implement the same code.I added the retry only to
enqueue
andenqueue_in
, not toexecute
, so that other SQL statements can be executed without automatically retrying on PGError.