Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join_ald_scenario() works with upper/lower sector/technology #172

Closed

Conversation

maurolepore
Copy link
Contributor

Relates to 2degreesinvesting/r2dii.match#257

Setup failing test for upercase sector/technology.

@maurolepore maurolepore marked this pull request as ready for review August 12, 2020 02:48
@maurolepore maurolepore marked this pull request as draft August 12, 2020 02:56
@maurolepore
Copy link
Contributor Author

Again I made this a draft -- I forgot to remove a dependency on purrr.

@maurolepore
Copy link
Contributor Author

Also I must fix this:

image

The suffix "_" in walk_() and modify_at_() is to signal that these
functions are 'like' the ones from purrr but not 'the' ones from
purrr.
@maurolepore maurolepore requested review from jdhoffa and removed request for jdhoffa August 12, 2020 15:28
@maurolepore maurolepore deleted the join-lowercase-ald-columns branch August 20, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant