Make logging configurable #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth_mon_lockreleased twice after loggingpg_auth_mondata.log_pg_auth_mon_data()acquires and releases theauth_mon_lock. The original PR had thereturnafter a call tolog_pg_auth_mon_data()to prevent the second LWLockRelease(auth_mon_lock);This
returnwas dropped during merging.The bug manifest as the inability to connect to a PG server with the following error logged immediately after
pg_auth_mondata:To fix it manually, remove
pg_auth_monfromshared_preload_librariesand restart the PG instance.pg_auth_mon.log_periodGUC variable to manage the frequency of logging. The value is measured in minutes; only non-negative values up to 10080 (length of one week) are accepted. The value of zero means logging is disabled.