Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Combine multiple change request activities of same PR into one line #88

Closed
1 task done
Andre601 opened this issue Aug 1, 2021 · 0 comments · Fixed by #90
Closed
1 task done
Assignees

Comments

@Andre601
Copy link
Member

Andre601 commented Aug 1, 2021

Please check these things before submitting your issue:

  • I searched for duplicate or closed feature request here

Is your feature request related to a problem? Please describe.
Currently does the Action seem to list every change requested, even if it was submitted as one comment (See this example) as its very own one.

Describe the solution you'd like
Recent-Activity should check if the PR the change request is from, is the same as previous change requests in the list.

To be more precise should the action do checks as follows:

  • When finding change request, check if one was found before for the list. If not, just add to list, otherwise continue with next step.
  • Check if previous action(s) for the list are also change requests. If yes, continue to next step, otherwise just add to list.
  • Check if the PR is the same as with the previous change requests found. If yes, merge them all into one text.

This probably requires another text for the case of combined change requests and maybe a {amount} placeholder to use.
Example:

messages:
  multiple_changes_requested: "🔴 Requested {AMOUNT} changes in {ID} in {REPO}"

The reason for a separate message would be, that a single change request could then be listed as Requested one change and not as Requested 1 change(s)

Describe alternatives you've considered
There aren't any

Additional context
I discovered this recently when checking my Profile README
image

@abhijoshi2k abhijoshi2k self-assigned this Aug 2, 2021
@abhijoshi2k abhijoshi2k mentioned this issue Aug 2, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants