Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add amount keyword #90

Merged
merged 13 commits into from
Aug 3, 2021
Merged

Add amount keyword #90

merged 13 commits into from
Aug 3, 2021

Conversation

abhijoshi2k
Copy link
Member

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any necessary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Combine multiple changes_requested events of PR review event into single line

Closes #88

@abhijoshi2k abhijoshi2k added minor Will be added to next minor release Status: In progress This pr or issue is in progress Priority: low Low priority for this issue/pr. labels Aug 2, 2021
PuneetGopinath
PuneetGopinath approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@PuneetGopinath PuneetGopinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand much

@Andre601 Andre601 mentioned this pull request Aug 2, 2021
Merged
7 tasks
Andre601
Andre601 requested changes Aug 2, 2021
View reviewed changes
@abhijoshi2k abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

The Pull request of @abhijoshi2k has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.

This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

@abhijoshi2k abhijoshi2k requested a review from Andre601 August 2, 2021 18:06
@abhijoshi2k
Copy link
Member Author

The workflow is working as expected. Please review and merge if there are no more changes required.

Andre601
Andre601 approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@Andre601 Andre601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know why you ask me for reviews here. I'm not a JS guy...

@abhijoshi2k abhijoshi2k merged commit d57b6c1 into main Aug 3, 2021
@abhijoshi2k abhijoshi2k deleted the add-amount-keyword branch August 3, 2021 18:02
@Andre601 Andre601 added the Type: enhancement New feature or request label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andre601 Andre601 Andre601 approved these changes

@PuneetGopinath PuneetGopinath PuneetGopinath approved these changes

Assignees
No one assigned
Labels
minor Will be added to next minor release Priority: low Low priority for this issue/pr. Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Combine multiple change request activities of same PR into one line
3 participants
@abhijoshi2k @Andre601 @PuneetGopinath