Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easily get the URL of the issue/comment/pull_request #42

Merged
merged 14 commits into from
May 19, 2021
Merged

Conversation

PuneetGopinath
Copy link
Member

@PuneetGopinath PuneetGopinath commented May 19, 2021

Thank you for contributing! Please check the following things before submiting your PR:

Required:

If necessary:

  • I have updated the README and documentation.
  • I have updated the ChangeLog with the changes I have made.

Description

For example, to get issue url you currently use ${urlPrefix}/${item.repo.name}/issues/${item.payload.issue.number} to get the URL of the issue or comment, instead you could easily use ${item.payload.issue.html_url} for issue url, ${item.payload.pull_request.html_url} for pull request url and ${item.payload.comment.html_url} for issue comment url.

This pr, will also fulfil a feature request, requested somewhere else: jamesgeorge007/github-activity-readme#54

Closes #


Note: we will close your PR without comment if you do not check the required boxes above and provide ALL requested information.

@PuneetGopinath PuneetGopinath marked this pull request as ready for review May 19, 2021 12:36
@PuneetGopinath PuneetGopinath requested a review from Andre601 May 19, 2021 12:37
@Andre601 Andre601 added the Type: enhancement New feature or request label May 19, 2021
@PuneetGopinath PuneetGopinath added the Status: Ready The Pull request is ready for reviews and getting merged label May 19, 2021
@github-actions
Copy link
Contributor

The Pull request of @PuneetGopinath has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.


This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 19, 2021

Note: this pr also changes run-build.yml workflow, it uses npm ci, but npm install will make it work better.

@Andre601
Copy link
Member

Will this be a new release or will there be other changes before a new release?

@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 19, 2021

Yes, there should be a new release, @Andre601 Is the issue you opened a bug report or feature request actually, in jamesgeorge007/github-activity-readme#54

@Andre601
Copy link
Member

Yes, there should be a new release, @Andre601 Is the issue you opened a bug report or feature request actually, in jamesgeorge007/github-activity-readme#54

Feature request

@PuneetGopinath
Copy link
Member Author

Ok, then next version is v1.4.0

@PuneetGopinath PuneetGopinath added Status: In progress This pr or issue is in progress and removed Status: Ready The Pull request is ready for reviews and getting merged labels May 19, 2021
@github-actions
Copy link
Contributor

The Pull request of @PuneetGopinath is no longer marked as Ready!

Maintainers should wait with merging the Pull request until it is marked as ready again.


This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

@PuneetGopinath PuneetGopinath marked this pull request as draft May 19, 2021 12:51
@PuneetGopinath
Copy link
Member Author

Releasing a new version should be v1.4.0 because, a new feature added means a new minor version, as we are following semver.org

@Andre601 Andre601 added the minor Will be added to next minor release label May 19, 2021
@PuneetGopinath PuneetGopinath added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels May 19, 2021
@PuneetGopinath
Copy link
Member Author

@abhijoshi2k Just waiting for your review

@github-actions
Copy link
Contributor

The Pull request of @PuneetGopinath has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.


This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

@PuneetGopinath PuneetGopinath marked this pull request as ready for review May 19, 2021 13:03
@abhijoshi2k
Copy link
Member

Note: this pr also changes run-build.yml workflow, it uses npm ci, but npm install will make it work better.

npm ci is faster and does not change the lock file according to docs. Then why go for npm install ?

@PuneetGopinath
Copy link
Member Author

Ok, then as you say will use npm ci

@abhijoshi2k
Copy link
Member

@PuneetGopinath squash and merge this time right?

@PuneetGopinath PuneetGopinath merged commit 477cc56 into main May 19, 2021
@PuneetGopinath
Copy link
Member Author

PuneetGopinath commented May 19, 2021

@abhijoshi2k Sorry, I did it

@PuneetGopinath PuneetGopinath deleted the update branch May 19, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Will be added to next minor release Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants