Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create Repo Event, PR Review Event and PR Review Comment Event and Add separate module for each event #50

Merged
merged 40 commits into from
May 22, 2021

Conversation

Andre601
Copy link
Member

Checks

I have...

  • read and understood the Contributing Guidelines
  • Updated any nessecary files such as the README.md and/or CHANGELOG.md.

Type of Pull request

  • Minor Change
    This Pull request doesn't break existing configuration.
  • Major Change
    This Pull request will break existing configuration.
  • Bug fix
    This Pull request will fix a (critical) bug.
  • Documentation
    This Pull request only changes documentation (README.md, CHANGELOG.md, etc.)
  • Other: __________

Description

Adds new options for displaying actions for creating a repository, commenting on a Commit or Pull request (Covered by the COMMENTS option) or Reviewing a Pull request.

This was made by @abhijoshi2k. I only made this draft PR to update the changelog :P

Closes #

@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 21, 2021
@PuneetGopinath PuneetGopinath added minor Will be added to next minor release Type: enhancement New feature or request labels May 22, 2021
@PuneetGopinath
Copy link
Member

@abhijoshi2k What is the Commit Comment Event in the title?
I think the title should be changed to Add Create Repo Event, PR Review Event and PR Review Comment Event and Add separate module for each event

@PuneetGopinath PuneetGopinath added Priority: medium Medium priority for this issue/pr. Status: In progress This pr or issue is in progress and removed Updates: documentation Improvements or additions to documentation labels May 22, 2021
@abhijoshi2k abhijoshi2k changed the title Add Create Repository event, Commit Comment Event and Pull request comment and review Event Add More Events May 22, 2021
@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 22, 2021
@abhijoshi2k abhijoshi2k marked this pull request as ready for review May 22, 2021 10:35
@abhijoshi2k
Copy link
Member

@Andre601 @PuneetGopinath

The events added are as follows:

CREATE_REPO:
    description: "How the 'create new repository' activity should be printed."
    default: "📔 Created new repository {REPO}"
    required: false

Disable String: create_repo

FORK_REPO:
    description: "How the 'fork repository' activity should be printed."
    default: "🔱 Forked {FORK} from {REPO}"
    required: false

Disable String: fork

WIKI_CREATE:
    description: "How the 'create wiki' activity should be printed."
    default: "📖 Created new wiki page {WIKI} in {REPO}"
    required: false

Disable String: wiki

ADDED_MEMBER:
    description: "How the 'added as collaborator' activity should be printed."
    default: "🤝 Became collaborator on {REPO}"
    required: false

Disable String: member

REVIEW_APPROVED:
    description: "How the 'review approved' activity should be printed."
    default: "👍 Approved {ID} in {REPO}"
    required: false
CHANGES_REQUESTED:
    description: "How the 'changes requested' activity should be printed."
    default: "🔴 Requested changes in {ID} in {REPO}"
    required: false

Disable String: review

RELEASE:
    description: "How the 'release' activity should be printed."
    default: "✌️ Released {ID} in {REPO}"
    required: false

Disable String: release

STAR:
    description: "How the 'starred' activity should be printed."
    default: "⭐ Starred {REPO}"
    required: false

Disable String: star

abhijoshi2k and others added 4 commits May 22, 2021 16:17
* Prepare Changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

* reorder links

Co-authored-by: Puneet Gopinath <[email protected]>
@abhijoshi2k abhijoshi2k added Status: Ready The Pull request is ready for reviews and getting merged and removed Status: In progress This pr or issue is in progress labels May 22, 2021
@github-actions
Copy link
Contributor

The Pull request of @Andre601 has been marked as Ready!

It can now be reviewed and/or merged by Maintainers.


This is an automated response created by a GitHub Action
Mentioning the bot won't have any effect!

@Andre601
Copy link
Member Author

I would assume the version will still be 1.4.0? Considering we didn't release that version yet would it make sense to keep.

@Andre601 Andre601 removed the Updates: documentation Improvements or additions to documentation label May 22, 2021
@github-actions github-actions bot added the Updates: documentation Improvements or additions to documentation label May 22, 2021
@PuneetGopinath
Copy link
Member

I would assume the version will still be 1.4.0? Considering we didn't release that version yet would it make sense to keep.

Yes, v1.4.0

@PuneetGopinath PuneetGopinath removed the Updates: documentation Improvements or additions to documentation label May 22, 2021
@PuneetGopinath PuneetGopinath merged commit f95cffa into main May 22, 2021
@PuneetGopinath PuneetGopinath deleted the add-events branch May 22, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Will be added to next minor release Priority: medium Medium priority for this issue/pr. Status: Ready The Pull request is ready for reviews and getting merged Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants