Support one byte int vectors - [MOD-8207] #5377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuyAv46
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5377 +/- ##
==========================================
+ Coverage 86.63% 87.56% +0.92%
==========================================
Files 195 196 +1
Lines 34809 34846 +37
==========================================
+ Hits 30158 30514 +356
+ Misses 4651 4332 -319 ☔ View full report in Codecov by Sentry. |
alonre24
reviewed
Jan 6, 2025
meiravgri
reviewed
Jan 6, 2025
alonre24
approved these changes
Jan 6, 2025
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
* [TEMP] define new types enum values * support new types * support JSON embeddings * [TEMP] remove temporary definitions * [TEMP] follow a VecSim branch with new types implemented * added basic tests for new int types * fix unit tests * Follow VecSim's main * follow an official VecSim tag (v7.99.2) * added another test (cherry picked from commit 0ba0c32)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
Support one byte int vectors - [MOD-8207] (#5377) * [TEMP] define new types enum values * support new types * support JSON embeddings * [TEMP] remove temporary definitions * [TEMP] follow a VecSim branch with new types implemented * added basic tests for new int types * fix unit tests * Follow VecSim's main * follow an official VecSim tag (v7.99.2) * added another test (cherry picked from commit 0ba0c32) Co-authored-by: GuyAv46 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Implement support for new vector types
INT8,UINT8.Mark if applicable