Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CONTRIBUTING.md for posts and pages #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md for posts and pages #7
Changes from 2 commits
f1b48d2
3dfe571
d4bde6d
ee88d03
1f735a3
69aa575
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should expand on "create an issue and branch".
Perhaps, "create an issue which explains briefly what you are planning to add (and can be used for discussion)".
Do we want people to work on forks? I think probably not, in which case should we say something about how to request access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. How about using the issue for discussion of the topic and ideas, then the PR for discussion of the actual content?
I'm ashamed to say I don't know what we should do about people requesting access. Is there any way you can do this through github, or is it a case of them sending me an email and then me adding them? This is my first time dealing with an "organisation" account too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just clarified the contributing guidance; I hope that's about right now.
It looks like users need to be added to an organisation; they can't request access through github. Perhaps we should provide a contact email for this. Personal or UKAEA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use UKAEA email.