CDR resulting from sub-account-client inbound calls has parent 'accountSid'

[otsakir]

When a registered client makes a call the related CDR record does not belong to the account the client belongs too but to its parent.

I've reproduced the issue like this:

• On a local instance i created a sub-account of [email protected]. I named it [email protected]
• Created a SIP client named 'orestis'
• Registered with 'orestis' using jitsi
• Made a call to the cloud instance at sip:[email protected] call succeeded.
• Checked CDRs using the Calls API. No CDRs under '[email protected]' account.
• Check CDRs using parent [email protected] account. The call is there having account SID "ACae6e420f425248d6a26948c17a9e2acf" (administrator).

looks like the owner of the CDR is wrong

[maria-farooq]

some more insights are:
it is happening for inbound calls, for outbound call account_sid is correct.
reason behind is that for inbound calls to a number, we are picking sid from account of number_number. if phone number belongs to parent then CDR will have account sid of parent, which is wrong.

[maria-farooq]

another test proved that:
if sub account make an inbound call to a phone-number owned by sub-account itself, in that case account-sid in CDR is correct (i.e. = sub-account-sid)

[maria-farooq]

Comprehensive Problem Statement:

When a sub-account-client dials a phone-number owned by parent-account: resultant CDR account-sid is parent-account-sid instead of sub-account-sid. Reason behind is that CallManager is picking sid based on account-sid of phone-number, since phone-number belongs to parent hence cdr belongs to parent account-sid.
This impacts Calls Api, as sub-account-holders are unable to see CDRs that were made toward parent-phone-number.

[maria-farooq]

Solution need to be decided here

[maria-farooq]

final solution as discussed with @deruelle is here
@gvagenas can you please also review

[maria-farooq]

so solution 3 is final, now time to impl:

Will add test cases for following case:

• Given sub-account-client dials phone-number owned by parent-account:resultant CDR account-sid should be equal to sub-account-sid (this is current bug)
• add impl
• run who test case http://ci.telestax.com/view/Restcomm/job/TelScale-restcomm-For-Specific-Branch/65/