Skip to content

Make SIP Number and SIP Client tied to an account and Unique per Organization #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
11 tasks done
maria-farooq opened this issue Apr 26, 2017 · 4 comments
Closed
11 tasks done

Make SIP Number and SIP Client tied to an account and Unique per Organization #2106

maria-farooq opened this issue Apr 26, 2017 · 4 comments
Assignees
@maria-farooq
Labels
Organizations

Comments

@maria-farooq
Copy link

maria-farooq commented Apr 26, 2017 •
edited
Loading

Use Cases:

  • Add new sip number should be possible even if that number exists in a different organization
  • Add new sip client should be possible even if that number exists in a different organization
  • Dialling a sip number means dialling that number of your(dialling client's) organization.
  • Dialling a sip client means dialling that number of your(dialling client's) organization.
  • upon sub account creation, tie the sub account to the same org as the parent.
  • Register clients with same login under their respective organizations.
  • monitoringservice metrics for registered users should distinctly identify users of all organizations #2128
  • verify existing test suit
  • update db changes in test suit
  • add new test in test suit
  • add upgrade scripts ( for numbers and client table changes)

@scottbarstow @deruelle do we want to support inter calls between client-to-number and client-to-client of different organizations?
For Example:
[email protected] dials [email protected]
or
[email protected] dials [email protected]
do you think that it is part of scope of this ticket or we should create a different issue for that?
@maria-farooq maria-farooq self-assigned this Apr 26, 2017
maria-farooq pushed a commit that referenced this issue Apr 26, 2017
added unit test for adding same sip client in 2 different Organizations
fe72d6a 
#2106
@deruelle
Copy link
Member

@maria-farooq looks good to me.

[email protected] dials [email protected] and [email protected] dials [email protected] only via Dial SIP not via dial client or dial number or dial conference, all of those should stay within an organization

maria-farooq pushed a commit that referenced this issue Apr 26, 2017
updated test #2106
dedda49
@scottbarstow
Copy link
Contributor

@maria-farooq this looks right to me as well. Jean can speak better to the inter-org, but what I'm not sure about is if we'd want to treat inter-org calls in your example as off-net, but I think this is a billing decision not a technical one. @deruelle comment on Dial SIP sounds right, tho I'm not deep in the weeds on that yet.

Either way I think we should treat that as separate ticket so that we can include test cases separately.

maria-farooq pushed a commit that referenced this issue Apr 26, 2017
updated call manager for resolving organization based on SIPUri Host …
60d8ab2 
…, updated getClientByLogin to include organization sid #2106
maria-farooq pushed a commit that referenced this issue Apr 26, 2017
updated CallManager and SMSService for org #2106
52f44e9
maria-farooq pushed a commit that referenced this issue Apr 26, 2017
handled UAM Register and MESSAGES as per org #2106
b643eb7
maria-farooq pushed a commit that referenced this issue Apr 27, 2017
tie the sub account to the same org as the parent #2106
66ad13f
maria-farooq pushed a commit that referenced this issue Apr 27, 2017
added organization_sid in restcomm_incoming_phone_numbers #2106
a15296e
maria-farooq pushed a commit that referenced this issue May 1, 2017
added org and in previous commit supported multiple addition of pureS…
71b81ff 
…ip numbers #2106
maria-farooq pushed a commit that referenced this issue May 1, 2017
#2106 implemeted: get number from same org, if not found then get non…
7c9ff77 
…-sip numbre from another org
maria-farooq pushed a commit that referenced this issue May 1, 2017
handled number resolution for SIP/SMPP/USSD messages #2106
a90fe29
maria-farooq pushed a commit that referenced this issue May 1, 2017
fixed constructor #2106
ec2c0bb
maria-farooq pushed a commit that referenced this issue May 4, 2017
register client with their respective organization #2106
268e5da 
added organizationSid in registrations dao and xml mapper files #2106
maria-farooq pushed a commit that referenced this issue May 4, 2017
updated hsql scripts for registrations #2106
c382daa
maria-farooq pushed a commit that referenced this issue May 4, 2017
updated registration dao and imple #2106
25c562a
maria-farooq pushed a commit that referenced this issue May 4, 2017
updated callmanager for registration #2106
7033ab1
maria-farooq pushed a commit that referenced this issue May 4, 2017
added default test domain for registration tests and fixed issue in S…
0f46942 
…IPURI UAM #2106
maria-farooq pushed a commit that referenced this issue May 5, 2017
added second client under differnt org #2106
a48bf46
maria-farooq pushed a commit that referenced this issue May 5, 2017
finalized registerMultipleUsersWithSameLoginUnderDifferentOrganizations
46cc8f8 
#2106
maria-farooq pushed a commit that referenced this issue May 5, 2017
fixed #2128 inside #2106
1773ce6
maria-farooq pushed a commit that referenced this issue May 5, 2017
updated data model as per latest impl #2106
1320822
maria-farooq pushed a commit that referenced this issue May 5, 2017
add new query for registration to fetch registration by location and …
8af9180 
…user for org #2106
maria-farooq pushed a commit that referenced this issue May 5, 2017
added logs for debugging why CM is unable to find number #2106
1ba2f7d
maria-farooq pushed a commit that referenced this issue May 5, 2017
replaced defaul with not null #2106
d9caf6e
maria-farooq pushed a commit that referenced this issue May 5, 2017
testsuit: added org in incoming phone number scripts #2106
57231d0
maria-farooq pushed a commit that referenced this issue May 10, 2017
fixed more hsql scripts #2106
bb2e428
@maria-farooq
Copy link
Author

maria-farooq commented May 10, 2017 •
edited
Loading

test suit packages verification

  • org.restcomm.connect.testsuite
  • org.restcomm.connect.testsuite.faultTolerance
  • org.restcomm.connect.testsuite.http
  • org.restcomm.connect.testsuite.provisioning.number.bandwidth
  • org.restcomm.connect.testsuite.provisioning.number.nexmo
  • org.restcomm.connect.testsuite.provisioning.number.vi (3 failing but they are failing in master as well)
  • org.restcomm.connect.testsuite.provisioning.number.voxbone (2 failing but they are failing in master as well)
  • org.restcomm.connect.testsuite.telephony.proxy
  • org.restcomm.connect.testsuite.telephony.ua
  • org.restcomm.connect.testsuite.smpp
  • org.restcomm.connect.testsuite.sms
  • org.restcomm.connect.testsuite.telephony

maria-farooq pushed a commit that referenced this issue May 10, 2017
fixed number addition bug #2106
38728c4
maria-farooq pushed a commit that referenced this issue May 15, 2017
updated hostname for sms tests #2106
83848c7
maria-farooq pushed a commit that referenced this issue May 15, 2017
updated hostname for sms test #2106
d02dee2
maria-farooq pushed a commit that referenced this issue May 15, 2017
update domainname with hostname only if hostname is not empty or null #…
eee64a3 
…2106
maria-farooq pushed a commit that referenced this issue May 17, 2017
fixed initial hsql records #2106
5a8b993
maria-farooq pushed a commit that referenced this issue May 17, 2017
fixed SMS number not found bug #2106
75c49e5
@maria-farooq
Copy link
Author

maria-farooq commented May 17, 2017 •
edited
Loading

Add New test for the feature:

  • Add same number in 2 (pre-configured) organizations @ org (other than 127.0.0.1)
  • Add same clients in 2 (pre-configured) organizations @ org (other than 127.0.0.1)
  • Dial number @ org (other than 127.0.0.1)
  • Dial client @ org (other than 127.0.0.1)
  • Dial sip from org1 to number@org2 (other than 127.0.0.1)
  • Dial sip from org1 to client@org2 (other than 127.0.0.1)
  • p2p messages between 2 clients of same organization
  • p2p messages between 2 clients of different organization (this one should fail)
  • inbound SMS terminating on app via SIP
  • inbound SMS terminating on app via SMPP
  • inbound USSD CALL terminating on app via SIP
  • Add registrations of 2 clients with same login in 2 (pre-configured) organizations
  • Test OPTIONS for registrations of 2 clients with same login in 2 (pre-configured) organizations

maria-farooq pushed a commit that referenced this issue May 17, 2017
Merge branch 'master' into issue-2073
7cde747 
* master:
  Minor patch for Restcomm testsuite failing tests
  Patch for CallManager to properly handle numbers that start with + This close #2158
  Patch to fix Outbound call never reach the completed state when inbound call sends BYE This close #2157
  Patch that fixes various Restcomm testsuite failing tests

Conflicts resolved:
	restcomm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/CallManager.java
#2106
@maria-farooq maria-farooq mentioned this issue May 18, 2017
Closed
maria-farooq pushed a commit that referenced this issue May 18, 2017
fixed #2160 #2106
833e8bd
maria-farooq pushed a commit that referenced this issue May 18, 2017
fixed organization twice sip number addition bug #2106 and added unit…
610e6d2 
… tests
maria-farooq pushed a commit that referenced this issue May 18, 2017
added test for testCreateNonPureSipPhoneNumbersForOrganizations #2106
a979671
maria-farooq pushed a commit that referenced this issue Jun 7, 2017
fixed test case for purchase non pure sip number #2106
524b956
maria-farooq pushed a commit that referenced this issue Jun 7, 2017
added dial action test for organizations #2106
23f0f8a
maria-farooq pushed a commit that referenced this issue Jun 11, 2017
#2106 mock ip resolution
54506f1
maria-farooq pushed a commit that referenced this issue Jun 14, 2017
integration and mock testing together #2106
c383e45
maria-farooq pushed a commit that referenced this issue Jun 16, 2017
completed mocking #2106
91fa1d1
maria-farooq pushed a commit that referenced this issue Jun 29, 2017
made getmostoptimalnumber common #2106
53ca0fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maria-farooq maria-farooq

Labels
Organizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deruelle @scottbarstow @maria-farooq