Skip to content

Properly handle exceptions in server-side password-validation #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
otsakir opened this issue May 31, 2017 · 0 comments
Closed

Properly handle exceptions in server-side password-validation #2175

otsakir opened this issue May 31, 2017 · 0 comments
Assignees
@otsakir
Labels
1. Bug
Milestone
Orestis Milestone 4

Comments

@otsakir
Copy link
Contributor

otsakir commented May 31, 2017

Password validation in server side is javascript based. In case there is a syntax error there there is no exception thrown. Proper error reporting is needed there.

Relates to #2077
@otsakir otsakir added the 1. Bug label May 31, 2017
@otsakir otsakir self-assigned this May 31, 2017
@otsakir otsakir added this to the Orestis Milestone 4 milestone May 31, 2017
otsakir added a commit that referenced this issue Jun 9, 2017
@otsakir
Restored error handling rational in case ScriptException is thrown
81f7f11 
- null is returned and the error is treated as a weak-password case
  since AccountsEndpoint:469 mutes all errors

Fixes #2175
@ghjansen ghjansen mentioned this issue Nov 14, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otsakir otsakir

Labels
1. Bug
Projects
None yet
Milestone
Orestis Milestone 4
Development

No branches or pull requests
1 participant
@otsakir