Skip to content

Paging Capabilities for IncomingPhoneNumbers API #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deruelle opened this issue Jun 5, 2017 · 17 comments · Fixed by #2238
Closed

Paging Capabilities for IncomingPhoneNumbers API #2189

deruelle opened this issue Jun 5, 2017 · 17 comments · Fixed by #2238
Assignees
@gvagenas @muhammadbilal19 @brainslog
Labels
2. Enhancement Critical_Importance Dashboard Help Wanted REST API UI
Milestone
George 8.2.0 Spri...

Comments

@deruelle
Copy link
Member

deruelle commented Jun 5, 2017

Need to implement Paging at API level and Dashboard level as well
@deruelle deruelle added this to the George 8.2.0 Sprint 4 milestone Jun 5, 2017
@jaimecasero
Copy link
Contributor

consider using Range header as in https://stackoverflow.com/questions/924472/paging-in-a-rest-collection
https://tools.ietf.org/html/rfc7233

@muhammadbilal19
Copy link
Collaborator

@deruelle @gvagenas Is anyone is working on that issue currently? because i am bit confuse as this issue has Help Wanted Label and assigned to some members as well. If it is still available i wanted to contribute for this issue.
I was just looking for some of other API's and just found that only Logs tab (Calls, Messages, Recordings, Transcriptions, Notifications and Conference) has paging functionality on API level as far i know.

@deruelle
Copy link
Member Author

deruelle commented Jun 7, 2017

@muhammadbilal19 we just created the issue yesterday so no one has had time to work on it yet. By all means, if you can take it on. It would make sense to actually create an issue per API not having paging functionality and do a PR per issue. What would be your estimate to complete this first issue ?

@muhammadbilal19
Copy link
Collaborator

Great @deruelle i will start looking into that issue and will share the estimate with you soon.

@deruelle
Copy link
Member Author

deruelle commented Jun 7, 2017

Awesome. Thanks @muhammadbilal19 looking forward to it

@maria-farooq
Copy link

Hi @muhammadbilal19,

Thanks for your interest.
We have a weekly public meeting on Wednesday 3pm UTC here https://gitter.im/RestComm/Restcomm-discuss.
If this time suits you, you can join and synch with team on progress of this task and other projects that team is working on.
Looking forward to seeing you there.

Thanks
Maria

@scottbarstow
Copy link
Contributor

Hi @muhammadbilal19 The urgency on this particular issue has gone up due to a customer with a huge quantity of phone numbers to manage.

If you don't have the time to get to this right away and provide a firm estimate we need to assign it to an internal resource.

If you could let me know by June 9 what you think that would be great.

We have several other APIs with the same issue that are lower priority that we'd love for you to take over if you don't have immediate time for this one.

Thanks for contributing!

@muhammadbilal19
Copy link
Collaborator

Hi @scottbarstow yesterday i started working on it and completed the API part this issue. Now i am playing with UI to show pagination on this module. Once i done with this changes and testing then i will create PR.

I pretty much hopeful to complete this issue by 10 June.

@scottbarstow
Copy link
Contributor

scottbarstow commented Jun 8, 2017 via email

@scottbarstow
Copy link
Contributor

scottbarstow commented Jun 8, 2017 via email

@scottbarstow
Copy link
Contributor

@muhammadbilal19 let's plan to do two PRs, one for the API changes and one for the UI changes so that we can have them reviewed internally in parallel.

Does that work for you?

@muhammadbilal19
Copy link
Collaborator

@scottbarstow sounds like a good plan i will finalise the API code and will create separate PR for API.Will try to fix sorting as well :)

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 8, 2017
@muhammadbilal19
RestComm#2189
5b319d7 
Add pagination changes for IncomingPhoneNumbers API
Add pagination changes on number-incoming.html
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 9, 2017
@muhammadbilal19
Add sorting by friendly_name and phone_number
c795e8a 
Change pagination footer like 1 to 10 of 1000
RestComm#2189
@muhammadbilal19
Copy link
Collaborator

muhammadbilal19 commented Jun 9, 2017 •
edited
Loading

@scottbarstow i created PR with API and UI changes #2211, I am managed to finish both the changes :)

@muhammadbilal19
Copy link
Collaborator

Some observations while i was fixing that issue

muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 9, 2017
@muhammadbilal19
Mybatis mapper for MySQL for pagination change RestComm#2189
2ad79f4
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 10, 2017
@muhammadbilal19
RestComm#2189
ba3d58d 
Add pagination changes for IncomingPhoneNumbers API
Add pagination changes on number-incoming.html
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 10, 2017
@muhammadbilal19
Add sorting by friendly_name and phone_number
3f2f964 
Change pagination footer like 1 to 10 of 1000
RestComm#2189
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 10, 2017
@muhammadbilal19
Mybatis mapper for MySQL for pagination change RestComm#2189
17ab793
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Adding test cases for pagination functionality of IncomingPhone
ccf03b6 
Add RestComm tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Revert "Adding test cases for pagination functionality of IncomingPho…
17f5252 
…ne Add RestComm tools class to remove some repeating code. Replace System.out to logger.info IncomingPhoneNumbersEndpointTest RestComm#2189"

This reverts commit ccf03b6.
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Adding test cases for pagination functionality of IncomingPhone
b0181e7 
Add RestCommIncomingPhone tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
RestComm#2189
b8ff71f 
Add pagination changes for IncomingPhoneNumbers API
Add pagination changes on number-incoming.html
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Add sorting by friendly_name and phone_number
fec68a7 
Change pagination footer like 1 to 10 of 1000
RestComm#2189
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Mybatis mapper for MySQL for pagination change RestComm#2189
72c0642
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Adding test cases for pagination functionality of IncomingPhone
4622be8 
Add RestComm tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Revert "Adding test cases for pagination functionality of IncomingPho…
cdd03dd 
…ne Add RestComm tools class to remove some repeating code. Replace System.out to logger.info IncomingPhoneNumbersEndpointTest RestComm#2189"

This reverts commit ccf03b6.
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Adding test cases for pagination functionality of IncomingPhone
d9405e9 
Add RestCommIncomingPhone tools class to remove some repeating code.
Replace System.out to logger.info IncomingPhoneNumbersEndpointTest 
RestComm#2189
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 12, 2017
@muhammadbilal19
Remove some extra parseInt code to improve performance RestComm#2189
7957dff
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 14, 2017
@muhammadbilal19
Fixed page size button and sorting issue RestComm#2189
ad11263
gvagenas added a commit that referenced this issue Jun 15, 2017
@gvagenas
Merge pull request #2211 from muhammadbilal19/issue-2189
bbaf3f6 
issue #2189
gvagenas added a commit that referenced this issue Jun 15, 2017
@gvagenas
Revert "issue #2189"
a70cb9d
gvagenas added a commit that referenced this issue Jun 15, 2017
@gvagenas
Merge pull request #2237 from RestComm/revert-2211-issue-2189
97aeee6 
Revert PR for "issue #2189"
muhammadbilal19 added a commit to muhammadbilal19/Restcomm-Connect that referenced this issue Jun 15, 2017
@muhammadbilal19
Merge last commited changes for RestComm#2189
593da4b 
Implement sorting with db query and start and end value fix RestComm#2189
This was referenced Jun 15, 2017
Merged
Open
Closed
Merged
@scottbarstow
Copy link
Contributor

@muhammadbilal19 this got deployed to our production instance today. Great work and thanks for taking care of all of this. Major uplift

@muhammadbilal19
Copy link
Collaborator

Thanks @scottbarstow for the update hopefully it will improve user experience. Hopefully soon we are able to deploy clients and account pagination as well.

@deruelle
Copy link
Member Author

Closing this issue. @muhammadbilal19 congrats and you have been acknowledged at https://telestax.com/acknowledgements/

@deruelle deruelle reopened this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvagenas gvagenas

@muhammadbilal19 muhammadbilal19

@brainslog brainslog

Labels
2. Enhancement Critical_Importance Dashboard Help Wanted REST API UI
Projects
None yet
Milestone
George 8.2.0 Sprint 4
Development

Successfully merging a pull request may close this issue.

Merge last commited changes for #2189 muhammadbilal19/Restcomm-Connect
7 participants
@deruelle @gvagenas @scottbarstow @jaimecasero @muhammadbilal19 @brainslog @maria-farooq