Skip to content

Child actors should be created using getContext().actorOf() #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gvagenas opened this issue Jun 21, 2017 · 3 comments
Closed

Child actors should be created using getContext().actorOf() #2274

gvagenas opened this issue Jun 21, 2017 · 3 comments
Assignees
@agafox
Labels
2. Enhancement

Comments

@gvagenas
Copy link
Contributor

...instead of getContext().system().actorOf().
This way the child actors will be terminated when the parent actor terminates
@gvagenas gvagenas added this to the George 8.2.0 Sprint 5 milestone Jun 21, 2017
@gvagenas gvagenas self-assigned this Jun 21, 2017
@gvagenas gvagenas removed this from the George 8.2.0 Sprint 5 milestone Jun 21, 2017
@gvagenas
Copy link
Contributor Author

And provide meaningful names to the actors when possible

@marca56 marca56 closed this as completed Jun 21, 2017
@marca56 marca56 reopened this Jun 21, 2017
@gvagenas
Copy link
Contributor Author

gvagenas commented Jun 21, 2017 •
edited
Loading

For example all actors created by Call actor should be children of Call actor, thus when Call actors terminated, all children will terminate also

@muhammadbilal19 muhammadbilal19 mentioned this issue Jun 22, 2017
Open
@agafox agafox assigned agafox and unassigned gvagenas Jun 22, 2017
@gvagenas
Copy link
Contributor Author

Akka documentation:

http://doc.akka.io/docs/akka/2.1.2/general/addressing.html [Creating Actors]
http://doc.akka.io/docs/akka/2.1.2/general/supervision.html [The Top-Level Supervisors]

agafox added a commit to agafox/Restcomm-Connect that referenced this issue Jun 29, 2017
@agafox
Child actors should be created using getContext().actorOf() RestComm#…
ec14a18 
…2274
gvagenas added a commit that referenced this issue Jul 7, 2017
@gvagenas
Modified test case to test child behavior on parent termination
78c16ea 
This refer to #2274
@agafox agafox closed this as completed Jul 7, 2017
maria-farooq pushed a commit that referenced this issue Jul 10, 2017
Merge branch 'master' into issue-1312
88fc315 
* master:
  - Patch for Recording and Dial with record, race condition - Patch for DialStatusCallback to don't execute the same state more than once This close #2332 This close #2335
  Work in progress for issue #2332
  Modified test case to test child behavior on parent termination This refer to #2274
  TLS_CLIENT_AUTH_TYPE configuration option.
  Fixes #2328 - config-rvd.sh if/then/else syntax bug
  Merge Issue-2274 with origin/master
  Testsuite improvements
  added ActorSupervisorStrategyTest
  RestcommSupervisorStrategy.getStrategy()
  Patch to don't block call actor on Stopping state waiting for MmsCallController response This close #2261
  added ActorSupervisorStrategyTest
  trying blackhub copilot
  Integrating black duck software copilot for license check
  hangupOnEnd default value bugfix
  Patch for race condition for Calls that execute Record verb and receive a Bye from client. This close #2313
  Child actors should be created using getContext().actorOf() #2274
maria-farooq pushed a commit that referenced this issue Jul 12, 2017
Merge branch 'master' into issue-2073
e9ec3be 
* master: (37 commits)
  closed #2341
  - Patch for Recording and Dial with record, race condition - Patch for DialStatusCallback to don't execute the same state more than once This close #2332 This close #2335
  Work in progress for issue #2332
  Modified test case to test child behavior on parent termination This refer to #2274
  Configure 'rvdUrl' in dashboard.json from advanced.conf/RVD_URL
  TLS_CLIENT_AUTH_TYPE configuration option.
  Fixes #2328 - config-rvd.sh if/then/else syntax bug
  Merge Issue-2274 with origin/master
  Testsuite improvements
  added ActorSupervisorStrategyTest
  RestcommSupervisorStrategy.getStrategy()
  Patch to don't block call actor on Stopping state waiting for MmsCallController response This close #2261
  added ActorSupervisorStrategyTest
  trying blackhub copilot
  Integrating black duck software copilot for license check
  fixed #2319
  hangupOnEnd default value bugfix
  Patch for race condition for Calls that execute Record verb and receive a Bye from client. This close #2313
  added DTMF_DETECTOR_TONE_INTERVAL #2303
  added MEDIA_MAX_DURATION #2317
  ...

Conflicts resolved:
	restcomm/restcomm.monitoring.service/src/main/java/org/restcomm/connect/monitoringservice/MonitoringService.java
	restcomm/restcomm.mrb/src/main/java/org/restcomm/connect/mrb/MediaResourceBrokerGeneric.java
	restcomm/restcomm.sms/src/main/java/org/restcomm/connect/sms/SmsSession.java
	restcomm/restcomm.sms/src/main/java/org/restcomm/connect/sms/smpp/SmppMessageHandler.java
	restcomm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/CallManager.java
	restcomm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/ua/UserAgentManager.java
	restcomm/restcomm.ussd/src/main/java/org/restcomm/connect/ussd/telephony/UssdCallManager.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agafox agafox

Labels
2. Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvagenas @agafox @marca56