WIP Voice Proposal 2b #2138
Merged
WIP Voice Proposal 2b #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ences to CallRequest.Type and CreateCall.Type to CreateCallType commons enum
…quest, IExtensionCreateSmsSessionRequest interfaces
…sionRequest. Decorate ExtensionRequest with IExtensionRequest interface
…ename preexisting x-headers to rcmlHeaders. Decorate CreateCall with IExtensionCreateCallRequest interface. Modify CM.outbound to use IExtensionCreateCallRequest to extensions. Modify outboundToPstn to use outboundProxy
abdulazizali77
force-pushed
the
MPROV_Voice2b
branch
4 times, most recently
from
a230349 to
b41ce41
Compare
…ing. Reorder methods
…ew comments: Remove CreateCall, unused *Response, change method interfaces. Remove CallManager.handleExtensionResponse. Add extension check for proxyDID scenario.
… host replacement
…ert mistaken rcmlHeaders functions changes, instantiate rcmlHeaders outside of if block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Change Extensions API to use mutable interfaces
-decorate existing classes with interfaces
-move
CreateCall.Typeto commons asCreateCallTypeTODO
-DESIGN: rename Interface methods to be more Extension specific? eg
getExtensionOutboundProxy()getExtensionType()?FIXME
CreateCall is defined as @immutable, should it be? or Mutable?