Fixes #2037 and #2039 #2227
Merged
Fixes #2037 and #2039 #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhien1807
changed the title
|
Hi @nguyenhien1807, Thanks for the contributions. We will review this shortly, but it's a good practice to keep each issue separated on it's own branch, and do separate Pull Requests from each branch. Keeping all changes on the same branch makes it harder to review and impossible to merge if some things are good and others aren't (not so much in this case, as the changes seem to be simple and separated, but still worth using best practices). Also working on master is not advised, master should be the reference point to be in sync with the original repository. |
|
Hi Alex, Thanks for your response. I'll take care of those things in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @ipsilantide and @ammendonca,
Please help me to review changes for these issues.
Regards,
Hien Nguyen