Issue 2038 remove yellow color #2239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nguyenhien1807 don't worry about Olympus for now, let's just focus on Restcomm Console for now. |
ammendonca
suggested changes
Jun 20, 2017
There was a problem hiding this comment.
Hi @nguyenhien1807,
The yellow is removed (it still flashes if going through the dropdown for selecting the autofill entry), but as I've mentioned previously at #2234, there's some discrepancy between if you autofill or type manually (in the example below, I've added and removed a letter to the autofill user, making the user with a grey background while the password has a white one)
Whatever we go for (white or grey background, @ipsilantide ?) it must be coherent.
|
@nguyenhien1807 I would like to keep it white if possible |
|
Thanks @nguyenhien1807, looks good now, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got to realize that I don't have code for Olympus now hence I applied the fixes for RestComm-Connect first.