Skip to content

Issue2230 configurable cors headers #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 30, 2017
Merged

Issue2230 configurable cors headers #2253

merged 8 commits into from
Jun 30, 2017

Conversation

otsakir
Copy link
Contributor

@otsakir otsakir commented Jun 20, 2017

Contains the following:

  • New response filter that selectively adds CORS (Access-Control-*) headers
  • Refactored restcomm.xml/rcmlserver configuration section
  • automated tests that check the existense of the CORS headers
  • New (not-authenticated) OPTIONS method for Accounts endpoint

The addition of the headers affects all requests in case the 'Origin' request header is present and matches configuration. However, the OPTIONS method is only added to the Accounts endpoint that is used by RVD. Maybe it makes sense to add OPTIONS method globally or handle it somehow centrally. I think this involves more analysis and is part of another issue/task.

otsakir added 8 commits June 15, 2017 13:06
@otsakir
Added allow-all CORS filter
a58dd00 
refers #2163
@otsakir
Reviewed restcomm.xml 'rcmlserver-api' section, configuration classes…
2805a23 
… and RcmlserverApi class

- renamed rcmlserver-api to rcmlserver
- added api-path property

Refers #2230
@otsakir
Fixed broken AccountsEndpointClosingTest
3feaa8f 
This relates to 'rcmlserver' configuration section since it used it

Refers #2230
@otsakir
Load restcomm.xml and initialize CorsFilter accordingly
ca24d22 
Refers #2230
@otsakir
Added OPTIONS method to AccountsEndpoint and refined security checks …
ef1d591 
…for endpoint's methods

Refers #2230
@otsakir
Reviewed CorsFilter initialization and added automated test
eb07167 
Refers #2230
@otsakir
Added log message upon initialization of CORS filter
66864c8 
Refers #2230
@otsakir
Merge branch 'master' into issue2230_configurable_CORS_headers
0db6385
@otsakir otsakir requested review from gvagenas and maria-farooq June 20, 2017 08:08
@otsakir otsakir mentioned this pull request Jun 21, 2017
Merged
@deruelle deruelle added this to the George 8.2.0 Sprint 5 milestone Jun 21, 2017
@deruelle deruelle requested review from leftyb and removed request for maria-farooq and gvagenas June 29, 2017 08:34
@deruelle deruelle assigned leftyb and unassigned gvagenas and maria-farooq Jun 29, 2017
@otsakir otsakir merged commit 0db6385 into master Jun 30, 2017
otsakir added a commit that referenced this pull request Jun 30, 2017
@otsakir
Merge branch 'cors_support_and_video_config'
9c5eddc 
Merges PRs #2136, #2253, #2268
@jaimecasero jaimecasero deleted the issue2230_configurable_CORS_headers branch November 21, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leftyb leftyb Awaiting requested review from leftyb

Assignees

@leftyb leftyb

Labels
REST API
Projects
None yet
Milestone
George 8.2.0 Sprint 5
Development

Successfully merging this pull request may close these issues.
5 participants
@otsakir @deruelle @gvagenas @leftyb @maria-farooq