Skip to content

Asr #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Sep 20, 2017
Merged

Asr #2500

merged 55 commits into from
Sep 20, 2017

Conversation

maria-farooq
Copy link

@maria-farooq maria-farooq commented Sep 15, 2017

related to PR https://github.com/RestComm/Restcomm-Connect/pull/2329
DA guys created above PR to merge into RestComm:master from YevgenL:asr
However we have been merging into RestComm:asr from YevgenL:asr
Hence this is main PR to merge ASR feature into RC master

Eugene Lapin and others added 30 commits July 7, 2017 15:56
Small fix of unsafe code
Update gather-rcml documentation
* master: (43 commits)
  Fix Olympus config for SECURESSL=FALSE
  Revert chart call duration conversion from seconds to minutes
  RVD undeployed by config at *first* restcomm start
  added the patch #2389
  added test cases for deleting/updatig a phonenumber that does not exists #2389
  Fixes for testsuite
  Keep autofill text color to grey instead of black
  Patch to fix misspelled Sms statusCallback attribute This close #2386
  fixed callsid in new recording test
  Patch for move to Pause after dialing an invalid client This refer to #2358
  Added comment for restcomm.xml configuration option This refer to #2346
  add section about officially supported language
  Deploy/undeploy bundled RVD through configuration
  dont split instance id from callsid
  trim callsid value after getting from header
  fixed hsql scripts
  fixed hsql script
  fixed the bug
  improved logging
  improved logging
  ...
Remove PartialCallback check. Add FinalResult tests
FinalSpeech support without PartialResult
Fix: Go to the next Verb after silent
Eugene Lapin and others added 12 commits August 17, 2017 09:17
Fix for DTMF from MediaServer
Added 'pr' parameter to ASR
* master:
  RESTCOMM-885: Add Multiprovider Extension REST API doc
  fixed https://telestax.atlassian.net/browse/RESTCOMM-757
  Patch to fix "completed" status callback comes up twice This close #2421
  Restcomm testsuite fixes
  Updated SS to build #778
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Patch for Restcomm acting as a proxy to disable SDP patching. Added additional tests This refer to #2391
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Patch to remove blocking on S3AccessTool This refer to #2339
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Patch for Restcomm acting as a proxy to disable SDP patching. This refer to #2391
  Fixes for testsuite
  Patch for Restcomm `acting-as-proxy` feature to provide option to disable SDP patching This close #2391
* master: (213 commits)
  Update Restcomm - Docker Quick Start Guide.adoc
  Update Restcomm - Docker Quick Start Guide.adoc
  Update Restcomm - Docker Quick Start Guide.adoc
  change port 80 to 8080
  manage the version of license-maven-plugin
  removed link of png files from organization index doc
  added componnet diagram
  DateTime added at MonitoringService response This close #2491
  Added some bullets in organization documentation
  Push Notification Server configuration
  HttpClient lazy initialization
  Fixed #2467: Update iOS quick start guide asciidoc to be in sync with latest release
  Fixed broken link to contributors guide
  added debug logging to push notification server interaction method
  added debug logging to push notification server interaction method
  Added explanation/comment to restcomm.xml - response-timeout
  added some more documentation
  Fix dynamic log level change.
  Push server HTTP request Content-Type is "application/json"
  updated hostname
  ...
* master:
  changed OS name
  Added fix for OSX mount issue
  removed unnesesary error log
@maria-farooq
Copy link
Author

following 3 test cases are failing on asr, we need to investigate why they are failing and fix accordingly

org.restcomm.connect.testsuite.telephony.TestDialVerbPartThree.testRecord_ExecuteRCML_ReturnedFromActionURL
org.restcomm.connect.testsuite.telephony.TestDialVerbPartThree.testRecord_ExecuteRCML_ReturnedFromActionURLWithNullFinishOnKey

DA guys are investigating

Eugene Lapin and others added 3 commits September 19, 2017 18:15
* master:
  patched #2504 close #2504
  Patch for Downloader support for TLSv1.1 and TLSv1.2 This close #2501 This close #RESTCOMM-1095 This close #RESTCOMM-1093
  Docker RAM requirements and address matching
  'SECURESSL' if condition rollback
  'SECURESSL' if condition fixed
  :stable removed from supported tags
  Port mappings correction
  'Docker Image in OSX host' removed
@maria-farooq
Copy link
Author

maria-farooq commented Sep 20, 2017

  • visual code review is ok

  • recording tests are ok

  • IvrAsrEndpointTest.testSuccessfulAsrScenario is failing and DA guys need to check this

  • running test suit again to final check and then we will merge.

Maria Farooq and others added 3 commits September 20, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants