Fixed 'IsPushEnabled' handling in update RC client API call #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would it make sense to add a test case similar to what Antonis mentioned failing in original issue #2503 |
jaimecasero
reviewed
Oct 9, 2017
| if (getBoolean("IsPushEnabled", data)) { | ||
| result = result.setPushClientIdentity(client.getSid().toString()); | ||
| } else { | ||
| result = result.setPushClientIdentity(null); |
There was a problem hiding this comment.
i guess this is the only meaningfull change of this PR. This method is strange, it receives a final Client not meant to be modified. Then we assigned to a new var without final, and then we returned the modified instance... not sure what is the reason for this, i know is not part of this PR. Wouldnt make more sense to declare argument as regular non final,rather than suggesting Client is not modified to be modified later...?
|
mostly ok to be merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.