Issue2480 Record refactoring #2569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch to properly modify VI, Call, IvrEndpoint to handle recording NTFY requests from RMS or handle failures on recording. Patch to modify MockMediaGateway to actually create recording file for test purposes. This close Restcomm-1086 This close Restcomm-1089 This close Restcomm-1088
# Conflicts: # restcomm/restcomm.mgcp/src/main/java/org/restcomm/connect/mgcp/MockMediaGateway.java # restcomm/restcomm.telephony/src/main/java/org/restcomm/connect/telephony/Call.java # restcomm/restcomm.testsuite/src/test/java/org/restcomm/connect/testsuite/telephony/DialRecordingAnswerDelayTest.java # restcomm/restcomm.testsuite/src/test/java/org/restcomm/connect/testsuite/telephony/DialRecordingTest.java # restcomm/restcomm.testsuite/src/test/resources/log4j.xml
This refer to #2480
This close #2480
| @@ -776,7 +776,7 @@ private void onStop(Stop message, ActorRef self, ActorRef sender) { | |||
| logger.error("Could not measure recording duration: " + e.getMessage(), e); | |||
| duration = 0.0; | |||
| } | |||
| if (duration.equals(0.0)) { | |||
| if (!duration.equals(0.0)) { | |||
There was a problem hiding this comment.
we just flipped the check here and did nothing further.
dont we want to add recording record inside this check to make sure its added only when recording duration is not 0
|
|
||
| } | ||
| } | ||
| // if (testing) { |
There was a problem hiding this comment.
lets remove this block instead of commenting
| } | ||
| // catch (IOException e) { |
There was a problem hiding this comment.
lets remove this block instead of commenting
| @@ -1880,6 +1880,8 @@ public FinishRecording(final ActorRef source) { | |||
| @SuppressWarnings("unchecked") | |||
| @Override | |||
| public void execute(final Object message) throws Exception { | |||
| logger.info("##### At FinishRecording, message: "+message.getClass()); | |||
| @@ -818,6 +818,7 @@ private void onMediaGroupResponse(Object message) throws TransitionFailedExcepti | |||
| } else if (is(playing)) { | |||
| fsm.transition(message, ready); | |||
| } else if (is(creatingRecording)) { | |||
| logger.info("Will move to finishRecording because of MediaGroupResponse"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: